Metapath expression evaluator subcommand#102
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ce00924 to
d3e3823
Compare
9226a3c to
047da2d
Compare
047da2d to
3f972ae
Compare
0a77e21 to
de07a9c
Compare
de07a9c to
5fb95f1
Compare
5fb95f1 to
4637af0
Compare
aj-stein-gsa
left a comment
There was a problem hiding this comment.
Non-blocking: I would like an example test of directly querying an instance of a document against the model in tests just to make it clear how it would work, but I am very happy with this new subcommand and will make plenty of use of it quite soon! 🚢
… improper handling of JSON keys. Added basic support for arbitrary Metapath command execution, building on metaschema-framework#96. Metapath execution allows for evaluating expressions without a module or instance. Resolves usnistgov/metaschema-java#241.
4637af0 to
209af33
Compare
|
awesome to see this! |
* introduce metapath expression evaluator subcommand * Fixed a schema generation bug causing an existing test to fail due to improper handling of JSON keys. Added basic support for arbitrary Metapath command execution, building on metaschema-framework#96. Metapath execution allows for evaluating expressions without a module or instance. Resolves usnistgov/metaschema-java#241. --------- Co-authored-by: wandmagic <156969148+wandmagic@users.noreply.github.com>
Committer Notes
This adds a new command that supports arbitrary Metapath evaluation in the command line interface (CLI).
The command is
metaschema-cli metapath eval.This PR also fixes an issue for the little used JSON key feature that was causing JSON schemas to not be generated properly when this feature was used. This was causing issues with unit testing this PR.
This PR builds on #96 and usnistgov/metaschema-java#267.
Resolves usnistgov/metaschema-java#241.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: