Skip to content

eslint: run via npx#2795

Draft
oliver-sanders wants to merge 2 commits intometomi:masterfrom
oliver-sanders:eslint
Draft

eslint: run via npx#2795
oliver-sanders wants to merge 2 commits intometomi:masterfrom
oliver-sanders:eslint

Conversation

@oliver-sanders
Copy link
Member

We really don't need to maintain an eslint lock file, we just need a vaguely up-to-date version.

@oliver-sanders oliver-sanders added this to the 2.3.x milestone Jun 28, 2024
@oliver-sanders oliver-sanders requested a review from MetRonnie June 28, 2024 12:41
@oliver-sanders oliver-sanders self-assigned this Jun 28, 2024
Comment on lines -8 to -11
"eslint-plugin-import": "^2.22.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^4.2.1",
"eslint-plugin-standard": "^5.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure running npx eslint would have any way of knowing about these plugin dependencies anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can enable them individually (and I initially did --package a --package b ...), however, I couldn't seem to find any functional difference from removing them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have to add a violation to one of the rules supplied by one of these plugins to see any difference

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what I tried yes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the latest run

ESLint couldn't find the config "standard" to extend from.

@oliver-sanders oliver-sanders marked this pull request as draft July 3, 2024 12:28
@oliver-sanders oliver-sanders modified the milestones: 2.3.x, 2.4.x Feb 25, 2025
@oliver-sanders oliver-sanders modified the milestones: 2.4.x, 2.5.x Sep 16, 2025
@oliver-sanders oliver-sanders removed this from the 2.5.x milestone Nov 3, 2025
@wxtim
Copy link
Contributor

wxtim commented Nov 24, 2025

@oliver-sanders Poke - what's the status of this one?

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Nov 24, 2025

Work not in progress. Would be good to do, one day...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants