rosie: re-enable Rosie Disco service#2985
Open
oliver-sanders wants to merge 4 commits intometomi:masterfrom
Open
rosie: re-enable Rosie Disco service#2985oliver-sanders wants to merge 4 commits intometomi:masterfrom
oliver-sanders wants to merge 4 commits intometomi:masterfrom
Conversation
oliver-sanders
commented
Jan 16, 2026
Comment on lines
+18
to
+21
| - sqlalchemy >=1,<2 | ||
| - tornado |
Member
Author
There was a problem hiding this comment.
Move rosie-only dependencies out of core dependencies:
$ git grep --name-only sqlalchemy -- metomi
metomi/rose/check_software.py
metomi/rosie/db.py
metomi/rosie/db_create.py
metomi/rosie/svn_post_commit.py
$ git grep --name-only tornado -- metomi
metomi/rose/check_software.py
metomi/rosie/ws.py
oliver-sanders
commented
Jan 16, 2026
| from tornado.ioloop import IOLoop, PeriodicCallback | ||
| import tornado.log | ||
| import tornado.web | ||
| import tornado.wsgi |
Member
Author
There was a problem hiding this comment.
Remove residual remains of WSGI support.
oliver-sanders
commented
Jan 16, 2026
| if port_is_busy "${TEST_ROSE_WS_PORT}"; then | ||
| pass "${TEST_KEY}" | ||
| TEST_ROSE_WS_URL="http://${HOSTNAME}:${TEST_ROSE_WS_PORT}/${NS}-${UTIL}" | ||
| TEST_ROSE_WS_URL="http://$(hostname -f):${TEST_ROSE_WS_PORT}/${NS}-${UTIL}" |
Member
Author
There was a problem hiding this comment.
For VDI test compat.
oliver-sanders
force-pushed
the
re-instate-rosie-disco
branch
from
022791d to
fd47528
Compare
Member
Author
|
Some long dormant tests are now running for the first time in a few years and need some TLC to recover from their long sleep. |
oliver-sanders
force-pushed
the
re-instate-rosie-disco
branch
from
fd47528 to
4458863
Compare
oliver-sanders
force-pushed
the
re-instate-rosie-disco
branch
2 times, most recently
from
518f3d2 to
4c18c96
Compare
oliver-sanders
force-pushed
the
re-instate-rosie-disco
branch
2 times, most recently
from
3c095b8 to
8ae98ae
Compare
* Remove vestigial remains of WSGI support (no longer an option via Tornado). * Fix tests.
* Fix issues with pretty format:
* Support `--format`:
* Fix error if things which are not fields are added to `--format`.
* Fix error displaying `access-list`.
* Fix error displaying a field if it is undefined for the row.
* Add support for `-H` option.
oliver-sanders
force-pushed
the
re-instate-rosie-disco
branch
from
9c70472 to
5cda350
Compare
oliver-sanders
commented
Feb 2, 2026
This comment was marked as resolved.
This comment was marked as resolved.
oliver-sanders
force-pushed
the
re-instate-rosie-disco
branch
from
5cda350 to
f9ab186
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
* Install all dependencies on Mac OS. * But blacklist `t/rosie-lookup/00-basic.t` which isn't presently working.
oliver-sanders
force-pushed
the
re-instate-rosie-disco
branch
from
f9ab186 to
af7ff0c
Compare
Member
Author
|
The traceback for a missing DB config is "as was", but have put in a safeguard and a test to accompany in the last commit. |
wxtim
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rosie lookup"pretty" format:rosie lookup"pretty" format:--formatoption.-H(no-header) option.