Skip to content

Add update_contact_list endpoint to add user to a list#73

Open
robypez wants to merge 1 commit intomhenrixon:masterfrom
robypez:patch-1
Open

Add update_contact_list endpoint to add user to a list#73
robypez wants to merge 1 commit intomhenrixon:masterfrom
robypez:patch-1

Conversation

@robypez
Copy link

@robypez robypez commented Aug 8, 2020

Missing endpoint that i need for my project

Missing endpoint that i need for my project
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 36b78f5 and detected 0 issues on this pull request.

View more on Code Climate.

@Willardgmoore
Copy link

I'm new to active campaign. @robypez Should I be looking into this gem or the active-campaign-rails gem, or just build it directly into the system? I'm not sure if this gem is working based on the status and dates I'm seeing on requests, commits, etc

@mhenrixon
Copy link
Owner

I'd accept the PR with test coverage and a working implementation: https://developers.activecampaign.com/reference#update-list-status-for-contact

Right now, it seems the implementation is broken.

@mhenrixon mhenrixon assigned mhenrixon and unassigned mhenrixon Sep 5, 2020
@mhenrixon mhenrixon added this to the API Version 3 milestone Sep 5, 2020
# @return [Hash] a hash with information about the newly created contact
#

"list": 2,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like proper ruby syntax to me?

"status": 1

def update_contact_list(params)
post("contactList", contact: params)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://developers.activecampaign.com/reference#update-list-status-for-contact it should be contact_list: params not contact: params

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the url is invalid, should be 'contactLists'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants