Skip to content

Clean up obsolete comments in ToolManager #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhingston merged 1 commit into from
Jan 10, 2026
Merged

Clean up obsolete comments in ToolManager #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions src/runner/executors/llm/tool-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,24 +73,6 @@ export class ToolManager {

// 2. Step Tools & Standard Tools
const standardToolsRecord = STANDARD_TOOLS as any; // Handle index signature issue
const extraTools = [
...(step.tools || []),
...(step.useStandardTools ? Object.values(standardToolsRecord) : []),
];

// Logic to merge standard tools correctly:
// If useStandardTools is true, we want all standard tools.
// But the loop above iterates over step.tools (definitions) + values?
// In original code: const extraTools = [...(step.tools || []), ...(step.useStandardTools ? STANDARD_TOOLS : [])];
// Wait, STANDARD_TOOLS is an object, not array.
// Original code issue: `step.useStandardTools ? STANDARD_TOOLS : []` -> if STANDARD_TOOLS is object, iterate?
// In original code: `for (const tool of extraTools)`
// If STANDARD_TOOLS is object, it is NOT iterable.
// The original code probably relied on `STANDARD_TOOLS` being iterable or `Object.values` was intended?
// Actually, `STANDARD_TOOLS` import in `llm-executor` might be different?
// No, strictly it probably failed if `useStandardTools` was true unless `STANDARD_TOOLS` is array-like.
// Let's assume `STANDARD_TOOLS` is a Record.
// I will iterate properly.

const toolsToRegister: any[] = [...(step.tools || [])];
if (step.useStandardTools === true) {
Expand Down