Cleaning code and type fixes for some lib/*.ts files #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahriggan
approved these changes
Mar 29, 2019
micahriggan
requested changes
Mar 29, 2019
| self.publicTxUrlTemplate = opts.emailOpts.publicTxUrlTemplate || {}; | ||
| self.subjectPrefix = opts.emailOpts.subjectPrefix || '[Wallet service]'; | ||
| self.from = opts.emailOpts.from; | ||
| console.log(this.templatePath); |
Owner
There was a problem hiding this comment.
which I committed accidentally
| var rejectors = _.map(data.rejectedBy, function(copayerId) { | ||
| return _.find(wallet.copayers, { | ||
| const rejectors = _.map(data.rejectedBy, (copayerId) => { | ||
| const copayer: any = _.find(wallet.copayers, { |
Author
There was a problem hiding this comment.
Removed to use 'Copayer' properly
| async.map( | ||
| recipientsList, | ||
| function(recipient, next) { | ||
| (recipient: any, next) => { |
Author
There was a problem hiding this comment.
Removed to use a new 'Recipient' interface
| } | ||
| }; | ||
|
|
||
| function getCredentials(req) { |
Owner
There was a problem hiding this comment.
I don't know that this function should be converted to an arrow function if it's not using this
Author
There was a problem hiding this comment.
It is the same, in this case I used arrow functions to declare all the functions with the same notation
… settings in readme docs
Fix (BWS Docs) - removed testnet in bitcore config requirement in README
[insight-previous] FIX: UI fixes for invalid txs
…Messages Fix: add Deprecated server messages
fix push notification server start
…itcore-node-http-port
…ode-http-port Adding ENV for http port
Relative readme file links
Gamboster
force-pushed
the
micahriggan/feature/bws-ts
branch
from
111562f to
bbb764f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning code for:
bchaddresstranslator.ts
blockchainexplorer.ts
blockchainmonitor.ts
emailservice.ts
fiatrateservice.ts
lock.ts
messagebroker.ts
notificationbroadcaster.ts
pushnotificationsservice.ts
server.ts
stats.ts