Clean code and type fixes for models #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamboster
changed the title
micahriggan
requested changes
Mar 29, 2019
| } | ||
|
|
||
| sign = function(copayerId, signatures, xpub) { | ||
| sign = (copayerId, signatures, xpub) => { |
| }; | ||
| } | ||
|
|
||
| setBroadcasted = function() { |
Owner
There was a problem hiding this comment.
All methods should be method(args) {
| comment: string; | ||
|
|
||
| static create = function(opts) { | ||
| static create = (opts) => { |
| singleAddress: boolean; | ||
| status: string; | ||
| publicKeyRing: string[]; | ||
| publicKeyRing: any[]; |
Author
There was a problem hiding this comment.
Here, if we do this:
this.publicKeyRing = _.map(this.copayers, (copayer) => { return _.pick(copayer, ['xPubKey', 'requestPubKey']); });
We get something like: Array<{xPubKey: string, requestPubKey: string}>
so string[] is not quite right .. That’s why I had put any[]
We could use Array<{xPubKey: string, requestPubKey: string}> to be more specific
^ Done
| id: copayerId | ||
| }); | ||
| getCopayer(copayerId): Copayer { | ||
| return _.find(this.copayers, (c) => c.id == copayerId); |
Owner
There was a problem hiding this comment.
could we just do this.copayers.find
… settings in readme docs
Fix (BWS Docs) - removed testnet in bitcore config requirement in README
[insight-previous] FIX: UI fixes for invalid txs
…Messages Fix: add Deprecated server messages
fix push notification server start
…itcore-node-http-port
…ode-http-port Adding ENV for http port
Relative readme file links
Gamboster
force-pushed
the
micahriggan/feature/bws-ts-2
branch
from
287befc to
ce1803a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete unnecessary requires
Clean and fix types for all current models