Skip to content

Perf/reduce memory #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
micahriggan wants to merge 2 commits into
base: fix/mempool-txs-while-syncing
Choose a base branch
from
Open

Perf/reduce memory #19

micahriggan wants to merge 2 commits into from

Conversation

@micahriggan
Copy link
Owner

@micahriggan micahriggan commented Jun 6, 2019 •
edited
Loading

Reduce extra buffer and string serialization of scripts, and instead get only data used.

TLDR;

  1. output._scriptBuffer already exists, so don’t need to do output.script.toBuffer()
  2. input.toObject() replaced for the properties it needed off of the object.

micahriggan
micahriggan commented Jun 6, 2019
View reviewed changes
micahriggan
micahriggan commented Jun 6, 2019
View reviewed changes
packages/bitcore-node/src/models/transaction.ts
mintHeight: height,
coinbase: isCoinbase,
value: output.satoshis,
script: output.script && output.script.toBuffer()
Copy link
Owner Author

@micahriggan micahriggan Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure most of the gains can come from here

micahriggan
micahriggan commented Jun 6, 2019
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@micahriggan