[FEAT] payprov2 #25
Open
[FEAT] payprov2 #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can now sync ETH and get wallet history for ERC20 tokens
ETH blocks were using the BTC transforms, fixed that
[Feat] Check if valid API
fix gasPrice
fix fee for sendmax
fix non-displaying address page bug
micahriggan
reviewed
Oct 1, 2019
| }); | ||
| let rawBody, headers; | ||
|
|
||
| try { |
Owner
There was a problem hiding this comment.
Since we just re-throw the error, we can remove this try catch, and just use
let { rawBody, headers } = await PayProV2._asyncRequest({
| }); | ||
| }) { | ||
| let rawBody, headers; | ||
| try { |
| }) | ||
| }); | ||
| let rawBody, headers; | ||
| try { |
| }) | ||
| }); | ||
| let rawBody, headers; | ||
| try { |
| } | ||
|
|
||
| let payProDetails; | ||
| try { |
| // BTC Response - ETH Response | ||
| if (_.has(responseData, 'instructions[0].requiredFeeRate')) { | ||
| const requiredFeeRate = responseData.instructions[0].requiredFeeRate; | ||
| if (requiredFeeRate > MAX_FEE_PER_KB) { |
Author
There was a problem hiding this comment.
I need to change it for:
MAX_FEE_PER_KB: {
btc: 10000 * 1000, // 10k sat/b
bch: 10000 * 1000, // 10k sat/b
eth: 50000000000, // 50 Gwei
},
Thanks
| } | ||
|
|
||
| // ETH Response | ||
| if (_.has(responseData, 'instructions[0].value')) { |
Owner
There was a problem hiding this comment.
You're going to want to loop through the instructions and build a transaction per instruction, rather than get the first index.
…-no-wait Broadcast ETH transactions without waiting for a block
Feature/eth uri
fix paypro signatures on BWC for ETH
gabrielbazan7
force-pushed
the
feat/payprov2
branch
11 times, most recently
from
9e5eaf0 to
bd53fa2
Compare
gabrielbazan7
force-pushed
the
feat/payprov2
branch
from
bd53fa2 to
78f5dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.