(Feature) Support custom placement of cooldown text #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmniCC is not continuing to be supported for prepatch and Midnight retail releases. As such it is valuable to be able to at least move the cooldown text which OmniCC originally provided. This commit introduces this functionality within Grid2.
Owner
|
This patch is not finished, it crashes due to variables not initialized/assigned. |
Author
|
Odd.. this worked locally. I'll take another look. Do you have a stack trace handy? |
Owner
|
No trace needed all new variables used in IndicatorIcon.lua and IndicatorIcons.lua
are undefined, because there is no code in IndicatorIcon.lua and IndicatorIcons.lua to assign values to those variables. |
Author
|
Right, I see what was missed, apologies for the extra work. I've opened a new PR with additional testing steps that I used to verify. #347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Thanks for this addon and the continued support. While setting up my UI during prepatch, I noticed that OmniCC is not continuing to be supported for prepatch and Midnight releases. However one key feature of OmniCC was being able to modify the placement of cooldown text on particular frames using rules (to avoid impacting other frames). This PR introduces the functionality to move cooldown text using similar configuration values as the stack text, namely justification and x/y offsets.
I've tested this on Retail Version: 12.0.0.65560.
I'm happy to iterate as needed to get this merged.
Thanks!