Skip to content

Remove deprecated FluentValidation.AspNetCore package (Issue #164)#187

Merged
avgalex merged 1 commit intomasterfrom
fix/issue-164-remove-deprecated-fluentvalidation-aspnetcore
Feb 14, 2026
Merged

Remove deprecated FluentValidation.AspNetCore package (Issue #164)#187
avgalex merged 1 commit intomasterfrom
fix/issue-164-remove-deprecated-fluentvalidation-aspnetcore

Conversation

@avgalex
Copy link
Member

@avgalex avgalex commented Feb 14, 2026

Summary

  • Replaced deprecated FluentValidation.AspNetCore 11.3.1 with FluentValidation.DependencyInjectionExtensions 12.0.0 in the test project
  • Bumped version to 7.0.4-beta.3
  • Updated CHANGELOG.md with release notes

Closes #164

Test plan

  • dotnet build succeeds with 0 errors
  • All 54 tests pass on net8.0
  • All 54 tests pass on net9.0
  • All 51 tests pass on net10.0

🤖 Generated with Claude Code

Replace FluentValidation.AspNetCore 11.3.1 with
FluentValidation.DependencyInjectionExtensions 12.0.0 in the test project.
Bump version to 7.0.4-beta.3.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@avgalex
Copy link
Member Author

avgalex commented Feb 14, 2026

@claude review this PR

@claude
Copy link

claude bot commented Feb 14, 2026

Claude finished @avgalex's task in 1m 12s —— View job


Code Review

  • Read repository guidelines (CLAUDE.md)
  • Review changed files
  • Analyze the package migration
  • Verify changelog and version updates
  • Provide comprehensive review feedback

Review Summary

This PR correctly addresses Issue #164 by removing the deprecated FluentValidation.AspNetCore package. The changes are minimal, focused, and well-documented. LGTM

Detailed Feedback

✅ Package Migration (test/MicroElements.Swashbuckle.FluentValidation.Tests/MicroElements.Swashbuckle.FluentValidation.Tests.csproj:16)

  • Correct replacement: FluentValidation.AspNetCore 11.3.1 → FluentValidation.DependencyInjectionExtensions 12.0.0
  • The replacement is appropriate since FluentValidation.AspNetCore was deprecated in FluentValidation 11.0 and removed entirely
  • FluentValidation.DependencyInjectionExtensions is the official successor package that provides the DI registration methods (AddValidatorsFromAssemblyContaining, AddValidatorsFromAssembly, etc.)
  • Consistency confirmed: All sample projects already use FluentValidation.DependencyInjectionExtensions 12.0.0, so this aligns the test project with the rest of the codebase

✅ Version Bump (version.props:4)

  • Version increment from 7.0.4-beta.27.0.4-beta.3 is appropriate for a dependency update in a pre-release version
  • Follows semantic versioning conventions for beta releases

✅ Changelog (CHANGELOG.md:1-4)

Test Coverage

According to your test plan:

  • ✅ Build succeeds with 0 errors
  • ✅ All 54 tests pass on .NET 8.0 and .NET 9.0
  • ✅ All 51 tests pass on .NET 10.0

The fact that all tests pass confirms that FluentValidation.DependencyInjectionExtensions provides all the necessary functionality previously obtained from FluentValidation.AspNetCore.

Minor Observations

No issues found. The PR is clean and focused on the single task of replacing the deprecated package.


@avgalex avgalex merged commit 9ed5bf7 into master Feb 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of deprecated package FluentValidation.AspNetCore

1 participant