Skip to content

Conversation

@marrobi
Copy link
Member

@marrobi marrobi commented Sep 10, 2025

As per #144 , these vars are need to register bundles in an unattended manner in the pipelines.

@marrobi marrobi changed the title Revert "Remove unused vars from workflows" Add TEST_ACCOUNT_CLIENT_ID & TEST_ACCOUNT_CLIENT_SECRET Sep 10, 2025
@marrobi marrobi requested a review from Copilot September 10, 2025 13:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds two new environment variables TEST_ACCOUNT_CLIENT_ID and TEST_ACCOUNT_CLIENT_SECRET to GitHub Actions workflows to enable unattended bundle registration in CI/CD pipelines.

  • Adds test account credentials as required secrets to workflows
  • Implements validation for the new required secrets
  • Passes the credentials through to the devcontainer execution environment

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/register_tre_bundle.yml Passes test account credentials as environment variables
.github/workflows/deploy_tre_reusable.yml Defines test account secrets as required inputs and adds validation checks
.github/workflows/deploy_tre_branch.yml Passes test account credentials to deployment workflow
.github/workflows/deploy_tre.yml Passes test account credentials to deployment workflow
.github/actions/devcontainer_run_command/action.yml Defines test account inputs and passes them to container environment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jonnyry jonnyry self-requested a review September 10, 2025 15:16
@marrobi marrobi merged commit 0b174a5 into main Sep 10, 2025
4 checks passed
@marrobi marrobi deleted the revert-74-remove_unused_vars_from_workflows branch September 10, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants