Skip to content

GitHub Issue #16 and #20 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NileshGhodekar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

GitHub Issue #16 and #20 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f92a0cd
GitHub Issue #16
NileshGhodekar Mar 30, 2023
15c9aef
GitHub Issue #20
NileshGhodekar Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/MIMConfigDocumenter/ConnectorDocumenter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1853,7 +1853,7 @@ orderby metaverseAttribute
{
var allImportFlowsXPath = Documenter.GetMetaverseXmlRootXPath(pilotConfig) + "/mv-data/import-attribute-flow/import-flow-set[@mv-object-type = '" + this.currentMetaverseObjectType + "']/import-flows[@mv-attribute = '" + metaverseAttribute + "']";
var precedenceType = config.XPathSelectElement(allImportFlowsXPath) != null ? (string)config.XPathSelectElement(allImportFlowsXPath).Attribute("type") : string.Empty;
var allImportFlows = config.XPathSelectElements(allImportFlowsXPath + "/import-flow");
var allImportFlows = config.XPathSelectElements(allImportFlowsXPath + "/import-flow[@cd-object-type = '" + this.currentDataSourceObjectType + "' and " + connectorIdXPath + "]");

var importFlowRank = 0;
var importFlowIndex = 0;
Expand All @@ -1864,12 +1864,6 @@ orderby metaverseAttribute
var importFlowConnectorId = ((string)importFlow.Attribute("src-ma") ?? string.Empty).ToUpperInvariant();

importFlowRank = precedenceType.Equals("ranked", StringComparison.OrdinalIgnoreCase) ? importFlowRank + 1 : 0;

if (importFlowConnectorId != connectorId)
{
continue;
}

importFlowRuleIndex = metaverseAttribute == previousMetaverseAttribute ? importFlowRuleIndex + 1 : 0;
previousMetaverseAttribute = metaverseAttribute;

Expand Down
12 changes: 7 additions & 5 deletions src/MIMConfigDocumenter/MetaverseDocumenter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,23 +776,25 @@ private void FillMetaverseObjectDeletionRuleDataSet(string objectType, bool pilo
if (deletionRule != null)
{
var deletionRuleType = (string)deletionRule.Attribute("type") ?? string.Empty;
var deletionRuleTypeText = deletionRuleType;

if (deletionRuleType.Equals("scripted", StringComparison.OrdinalIgnoreCase))
{
deletionRuleType = "Rules Extension";
deletionRuleTypeText = "Rules Extension";
}
else if (deletionRuleType.Equals("declared-any", StringComparison.OrdinalIgnoreCase))
{
deletionRuleType = "Delete the metaverse object when connector from any of the following management agents is disconnected";
deletionRuleTypeText = "Delete the metaverse object when connector from any of the following management agents is disconnected";
}
else if (deletionRuleType.Equals("declared-last", StringComparison.OrdinalIgnoreCase))
{
deletionRuleType = "Delete the metaverse object when the last connector is disconnected. Ignore from the following list of management agents";
deletionRuleTypeText = "Delete the metaverse object when the last connector is disconnected. Ignore from the following list of management agents";
}

Documenter.AddRow(table, new object[] { objectType, deletionRuleType });
Documenter.AddRow(table, new object[] { objectType, deletionRuleTypeText });
var connectorList = deletionRuleType.Equals("declared-last") ? deletionRule.Elements("exclude-ma") : deletionRule.Elements("src-ma");

foreach (var connector in deletionRule.Elements("src-ma"))
foreach (var connector in connectorList)
{
var connectorId = ((string)connector ?? string.Empty).ToUpperInvariant();
var connectorName = (string)config.XPathSelectElement(Documenter.GetConnectorXmlRootXPath(pilotConfig) + "/ma-data[translate(id, '" + Documenter.LowercaseLetters + "', '" + Documenter.UppercaseLetters + "') = '" + connectorId + "']/name");
Expand Down