-
Notifications
You must be signed in to change notification settings - Fork 8
Configurable components #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kanak8278
wants to merge
6
commits into
microsoft:main
Choose a base branch
from
kanak8278:configurable_comp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a23f204
feat: Add i18n support for DevBotFooter component
kanak8278 3bbc554
feat: Add useConfig hook for retrieving configuration data to selecti…
kanak8278 ab8026f
feat: Enable DSL file upload, dev mode header, and code representations
kanak8278 fc9117b
feat: DSL file upload button in editor page
kanak8278 c83e120
Updated config.json
kanak8278 aca8616
feat: Add lazy loading for images in DevBotFooter component
kanak8278 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { useState, useEffect } from 'react'; | ||
| import config from '../locales/config.json'; | ||
|
|
||
| const useConfig = () => { | ||
| const [configData, setConfigData] = useState(null); | ||
|
|
||
| useEffect(() => { | ||
| setConfigData(config); | ||
| }, []); | ||
|
|
||
| return configData; | ||
| }; | ||
|
|
||
| export default useConfig; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "features":{ | ||
kanak8278 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "dslFileUpload": true, | ||
| "publishModal.publishButton": true, | ||
| "devFooter.uploadFiles": true, | ||
| "editorPage.devModeHeader": true, | ||
| "representation.nlr":true, | ||
| "representation.chart": true, | ||
| "representation.dsl": true, | ||
| "representation.code": false, | ||
| "error.errors": true, | ||
| "error.warnings": true, | ||
| "error.optimizations": true, | ||
| "error.botExperience": true | ||
|
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a default config always. We don't need such a long if block