build 1.6.7 version pip package #386
Open
+38,764
−9,377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cmake` throws an error if the `ThirdParty/zstd/build/cmake` git submodule is not cloned before the build: ``` CMake Error at CMakeLists.txt:96 (add_subdirectory): add_subdirectory given source "ThirdParty/zstd/build/cmake" which is not an existing directory. ``` So update the install command to avoid more users running into this. See #320 Co-authored-by: MaggieQi <chenqi871025@gmail.com>
* improve performance and memory usage * fix CLRCore build * clean code * align the cosine with production * remove the quantizer check between search head index and ssd index. * remove some freq condition check * unify AsyncReadRequest Co-authored-by: chenqi <cheqi@microsoft.com> Co-authored-by: Philip Adams <35666630+PhilipBAdams@users.noreply.github.com>
Co-authored-by: jinweizhang <jinweizhang@microsoft.com>
Fix GPU PQ build errors and added error checks
* GPU KNN Intergrate * Merged cuda hxx files * Remove extra files, fix CoreLibrary build * GPU code needs to be in cu file * break circular including * Rearranged the method * Included the files like Neighborhood Graph. h did. Only included need files in Kernel.cu * Relocate the Quey_KNN to KNN.hxx (templates cannot be in kernel.cu * Try to Instantizate before compile * Fixed compile error. Need GPU to test rest * Set Mem Failure * Adjusted the max dimension for vectors up ot 184 * Change DistCalMethod * Print Thread Start/End * Shared memory * Cannot launch Kernelr with 60% MaxSharedMemory * Root Cause: Transpose_Mem * L2 480s, Cosine 703s after Transpose * Two functions for Shared and local ThreadHeap, two launch setting with shared and local DistPair * Test version for Ben. 32 Threads defined in params.h query_KNN has transpose and all shared memory. query_KNN has transpose and heamMem in local. * Found the debugger issue, next step: fix dist calc * 1. Fixed int8 dist calc 2. Tested batch splitting on 35M 3. Moved the malloc before launching to avoid waste of memry * 45cap, monitor mem usage, track where Convert failed * Succeed on 400M 100D, Fixed int overflow, major change: int to size_t * Multi-GPU detection * Fixed the CPU mem over-usage, located the bug in updating results * Fixed multi free results * Fixed hard coded Cosine DistCalcMethod * Relocate the Point & Transposed Point to GPUKNNDistance.hxx * Merge SPTAG current changes, complaining about cuh cuda lib * Move Generate Truth to TruthSet.cpp * Fix optimization issue, add GPUCoreLibrary/GPUSSDServing to default build * Fix Error for Linux cmake. * Remove Unnecessary Changes. * restore datasets * missing s in folder name * Restore build config to Lib, restore sln Config * update tlog for lib config * Remove Wrappers * Removed not ignored log info * Remove Static in TruthSet.cpp Remove debug command, build GPU SSDServing to exe in Debug * Recover CL compile for GPU SSDServing/main.cpp Co-authored-by: diegocai <diegocai@microsoft.com> Co-authored-by: Philip Adams <philipadams@microsoft.com> Co-authored-by: Diego-Cai <103398280+Diego-Cai@users.noreply.github.com>
…tion (#339) * Fix bug with int8/cosine configuration, and enabled hardware optimization for this case. * Trigger CI Co-authored-by: diegocai <diegocai@microsoft.com>
* add nni_auto_tune * support other data format and add more result * add result picture * refine readme * refine readme * refine code style * update readme and datareader * add aml training config * update config * fix licence * refactor for data type * refactor for data type * refactor for data type * fix overflow on bruteforce * fix compute metric by index * add limits and preprocessing * change code dir Co-authored-by: Guoxin <suiguoxin@gmail.com> Co-authored-by: MaggieQi <chenqi871025@gmail.com>
* Fixed bugs with accuracy fix for TPT build with recon vectors * Accuracy fix working for GPU index build with PQ/OPQ enabled * Fix bug with accuracy fix * Trigger CI * Fix low accuracy issue with GPU index build for int8/cosine configuration (#339) * Fix bug with int8/cosine configuration, and enabled hardware optimization for this case. * Trigger CI Co-authored-by: diegocai <diegocai@microsoft.com> * Add nni_auto_tune example (#325) * add nni_auto_tune * support other data format and add more result * add result picture * refine readme * refine readme * refine code style * update readme and datareader * add aml training config * update config * fix licence * refactor for data type * refactor for data type * refactor for data type * fix overflow on bruteforce * fix compute metric by index * add limits and preprocessing * change code dir Co-authored-by: Guoxin <suiguoxin@gmail.com> Co-authored-by: MaggieQi <chenqi871025@gmail.com> * Fixed bugs with accuracy fix for TPT build with recon vectors * Accuracy fix working for GPU index build with PQ/OPQ enabled * Fix bug with accuracy fix * Trigger CI Co-authored-by: diegocai <diegocai@microsoft.com> Co-authored-by: smallv0221 <33639025+smallv0221@users.noreply.github.com> Co-authored-by: Guoxin <suiguoxin@gmail.com> Co-authored-by: MaggieQi <chenqi871025@gmail.com>
* Remove Transposed Point to save shared Memory * Add Generate GT int8 Dim to 768, add CUDA CHECK to debug, Add infty for uint32 * Fix sharedmem usage for K=100 gt Co-authored-by: Diego Cai <diegocai@microsoft.com> Co-authored-by: MaggieQi <chenqi871025@gmail.com>
* Fix build issue and windows issue with is_same_v * fix is_same_v error
* update python to python3 * use dynamic linking * enable ANNIndexTestTool code compiling * add python version in wheel package * update nuspec * enable to set different maxcheck and hashexponent * change to configure python version * trigger azurepipeline * trigger * fix python version * fix python version * fix python version in windows * fix cosine kmeans * clean avx/see header files * fix nuspec Co-authored-by: cheqi <cheqi@SRGSSD-07>
* prevent SimpleBufferIO fails to resize * Set put area for SimpleBufferIO * Update DiskIO.h
* add winrt projects * add gitignore for VS files * retarget to vc142 * make neighborCount uint32 * api takes byte[] for metadata * enable CFG and disable incremental linking to make BinSkim pass * format * remove edit and continue /ZI since it's incompatible for CFG * remove arm/arm64 platforms
* modify for thread_local context * fix initialization issue * fix ExtraWorkSpace id issue * fix workSpacePool * set thread affinity * add more affinity strategies * fix cmake compiler * fix linux libnuma compile * fix compiling and core bind * fix NumaStrategy and OrderStrategy enum type * remove space * Clear the workspace to ensure the heap size and pagebuffer size * User-overrideable worskpace implementation draft (#362) * make it possible to override workspace implementation * bool -> ErrrorCode * SPANN index should allow setting child index workspace * finish replacing by workspace factory * switch to unique_ptr * unresolved external * linux build error * windows build error --------- Co-authored-by: cheqi <cheqi@SRGSSD-07> Co-authored-by: Philip Adams <35666630+PhilipBAdams@users.noreply.github.com>
I have gone to "https://sourceforge.net/projects/boost/files/boost-binaries/1.67.0/" and downloaded "boost_1_67_0-msvc-14.1-64.exe", but encountered this failure during cmake -- Could NOT find Boost (missing: system thread serialization wserialization regex filesystem) (found suitable version "1.67.0", minimum required is "1.66") CMake Error at src/legacy/sptag/SPTAG/CMakeLists.txt:90 (message): Could not find Boost >= 1.67! I've notice that there are no precomiled libs, and had to run bootstrap + build exe to get the compiled libs. Co-authored-by: Philip Adams <35666630+PhilipBAdams@users.noreply.github.com>
* add filter support for BKT index * put the nullptr check into the upper function instead of #define, and add filter checking before duplicated check --------- Co-authored-by: Qianxi Zhang <qiazh@microsoft.com> Co-authored-by: Qianxi Zhang <Qianxi.Zhang@microsoft.com> Co-authored-by: MaggieQi <chenqi871025@gmail.com>
* rename logging macro to avoid name conflicts * fix rename * resolve merge --------- Co-authored-by: MaggieQi <chenqi871025@gmail.com>
* Allow setting a different Logger at runtime Mutex is needed here because Logger::Logging is not const, so we can mangle things if shared_ptr is not updated atomically. And specialization for std::atomic<std::shared_ptr<T>> isn't availible to us in C++17 * Missed one file * use atomics
… to support lambda expression (#371) Co-authored-by: Qianxi Zhang <Qianxi.Zhang@microsoft.com>
…n graph refine (#369) * add protections against overflow and size mismatch, and invalid IDs * avoid compilation issue * add more safety to rebuild job * add check to RNG * try to resolve gcc compiler issue * debug-guard expensive check * fix the logging macro * make it more branch-predictor friendly * transform macro into function * turn KDT macro to function * special case for index==-1 * Update to LL_ERROR * prevent extra allocations in BKT search by templated search function * static dispatch in KDT index * fix RNG prefetching * skip checking index in graph traversal, since we will check in At * dispatch by switch instead of if for fewer branches, use AlwaysTrue when filterFunc is null to allow compiler to optimize * make the template function naming easier to understand, formatting improvements * make checks in RebuildNeighbors IF_DEBUG only
Co-authored-by: Menghao Li <menghaoli@microsoft.com>
* Add support for and error checking for 384 dim and other PQ dimensions * Fix error message for GPU code --------- Co-authored-by: MaggieQi <chenqi871025@gmail.com>
* add .net core support * add linux nuget * fix linux nuspec * fix CsharpClient.vcxproj * fix Linux and Windows conflict * fix windows nuget package * add dump and loadfromdump * fix setup.py * fix cuda LOG * fix GPU log * fix Dockerfile for ubuntu20.04 * fix Dockerfile --------- Co-authored-by: cheqi <cheqi@SRGSSD-07>
* add logger for total distance * enhance syncing code execution. * change typo --------- Co-authored-by: MaggieQi <chenqi871025@gmail.com>
* avoid off-by-one due to post-increment in do-while comparison * Update to not miss last BKT node * syntax
* add .net core support * add linux nuget * fix linux nuspec * fix CsharpClient.vcxproj * fix Linux and Windows conflict * fix windows nuget package * add dump and loadfromdump * fix setup.py * fix cuda LOG * fix GPU log * fix Dockerfile for ubuntu20.04 * fix Dockerfile * add new apis for CLRCore * fix CLR version * fix test case * add quantizevector and reconstructvector support * fix quantizeVector * fix CLR build * fix fresh BKT bug * update swig to 4.0.0 * fix README --------- Co-authored-by: cheqi <cheqi@SRGSSD-07>
This pr is auto merged as it contains a mandatory file and is opened for more than 10 days.
…e DeletedIDs set (#391)
* outline convenience function changes * implement GetPostingDebug * fix make_shared of abstract class * dont need to change VectorIndex.h interface * resolve build
…problematic when dealing with binary metadata (like zstd-compressed data). Turns out we don't need to use the GetMetadataOffsets function since we're always adding one vector+one metadata at a time. So we will treat the metadata as one continuous chunk of data. (#393)
* remove unnecessary checks * fix multithread threadaffinity issue --------- Co-authored-by: cheqi <cheqi@SRGSSD-07>
Co-authored-by: denisyang <denisyang@tencent.com>
* add iterator interface * add relaxed mono signal in the interface * add batch in iterator interface * IterativeScanTest: change delete flag to false in Search * enable iterator and relax monotonicity support in java, python and c# * avoid queryresult empty issue * fix Iterator issue * clean code for SPANN * fix CLR compiling * add result check for IterativeScan * add iterator for spann * fix SSDTest bugs * remove logs in truthset * trigger the pipeline * add iterator example for python tutorial * modify the README --------- Co-authored-by: Qianxi Zhang <qiazh@microsoft.com> Co-authored-by: Qi Chen <cheqi@microsoft.com>
Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.4.0 to 10.0.1. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@9.4.0...10.0.1) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: MaggieQi <chenqi871025@gmail.com>
* Initial unit tests and KNN build test * Fix linking error * Fix TPT tests * Change test files and fix tpt test issues * Fix linking issues * Fix buildssd tests and add new tests - new bug with SPTAG logger when running tests * Add benchmark tests for PQ optimization --------- Co-authored-by: MaggieQi <chenqi871025@gmail.com>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
* batch ReadBlocks
* add batchSize option
* add timeout support for batched I/O
* Refine Index
* debug refine
* modify for stress test
* change update from metadata to mapping
* modify
* add IOStatistics for SPDK
* change ssd size
* modify for stress test
* fix ssd usage bug
* fix io limit
* modify ssd size for stress test
* for io stat
* modify for io
* fix for stress test
* temporarily remove rebuild
* fix BKT bug
* merge changes from Index.h BKTIndex.cpp
and RelativeNeighborhoodGraph.h
* add lock for mapping
* fix merge bug
* Improve README.md
* add loading exclude head
* modify length
* fix code with AE repo
* add checkpoint & move rocksdb to thirdparty
* fix zstd dependency
* fix compiling
* fix running on SPDK
* enable rocksdb, need to debug update
* fix update
* add SPDK & Rocksdb checkpoint function
* pass test for checkpoint, todo: add persistentbuffer
* add wal logic
* Add ExtraFileController
* Add ThreadPool and ReadBlocks
* Add WriteBlocks
* Add FileIO::BlockController::ShutDo()wn, IOStatisti();s, Modify FileIO::BlockController::ThreadPool()
* Add FileIO::FileIO()
* Add FileIO::{At(), Get(), Put(), ::BlockController::{Checkpoint(), Recovery()}}; Modify FileIO::BlockController::InitializeFileIo()
* Add FileIO::Merge()
* Roughly finish ExtraFileController
* Pass the test
* Add lock for FileIO
* Remove InterlockedCompareExchange and fix ThreadPool timer
* Try mem cache
* Fixed bugs in mem cache
* Remove log for mem cache
* Debug version
* Add Debug function
* Fix bug in AddPages
* modify ShutDown
* Modify create file
* Fix bug in ShutDown
* Add monitor thread
* Add Async IO
* Fix bugs in IOStatistics
* pre alloc iocb
* Remove ThreadPool
* Add KeyValueTest
* Modify KeyValueTest
* Finish KeyValueTest
* Add Conflicting test
* Add Merge test
* Add timeout
* Add new functions
* Add FileIOInterface
* Fix bugs in io setup
* Remove useless statement
* Add new apii
* Add new api
* Remove useless code
* Add Scan
* Add Write Cache (Still has bugs)
* Modify implementation of LRUCache
* Add Sharded LRU Cache
* Modify IOStatistics
* fix LoadIndex and FileIO BuildIndex
* fix thread_local variable does not init
* fix read
* reclean the logs
* add Script_AE
* fix build and search
* fix build + search
* fix file io save and load issue
* enable multifile setting
* update build_spresh.sh to enable fileio build and update testing
* update to vc143
* Merge SPFresh (#424)
* Initial commit
init from update version
merged code
backup
continue
update the initial work version
fix ExtraDynamicSearcher
fix vectorTranslateMap
fix compiling issues
fix compling
fix compiling
add merge
add merge re-assign
TODO: add steady state test
init steady state test
Init SPDKIO
optimize split
fix align_round
modify steady state: delete after search
modify trace
need to figure out disk usage
modify steadystate
need to debug load index
fix delete by metadata
add spfresh exe
finish benchmark
steady state complete
add KVTest
fix compiling errors
Init SPDKIO
optimize split
add KVTest
fix compiling errors
change update vector to partital read
modify merge
fix build
mem impl
fix correctness
Refactor code
add spdk as module
add isal-l_crypto as submodule
initial spdk integration
build queue infra
spdk working
add reference bdev.json
static spfresh search done
need to debug split
debug for GC/ReAssign
finish debug for GC/ReAssign
Add build guide for SPDK version
remove rocksdb
add timeout support for SPDK
modify code for timeout support
fix timeout bug
fix writeblocks segmentation fault
fix bug: SPDK init fail
fix timeout bugs
batch ReadBlocks
add batchSize option
add timeout support for batched I/O
Refine Index
debug refine
modify for stress test
change update from metadata to mapping
modify
add IOStatistics for SPDK
change ssd size
modify for stress test
fix ssd usage bug
fix io limit
modify ssd size for stress test
for io stat
modify for io
fix for stress test
temporarily remove rebuild
fix BKT bug
merge changes from Index.h BKTIndex.cpp
and RelativeNeighborhoodGraph.h
add lock for mapping
fix merge bug
Improve README.md
add loading exclude head
modify length
fix code with AE repo
add checkpoint & move rocksdb to thirdparty
fix zstd dependency
fix compiling
fix running on SPDK
enable rocksdb, need to debug update
fix update
add SPDK & Rocksdb checkpoint function
pass test for checkpoint, todo: add persistentbuffer
add wal logic
Add ExtraFileController
Add ThreadPool and ReadBlocks
Add WriteBlocks
Add FileIO::BlockController::ShutDo()wn, IOStatisti();s, Modify FileIO::BlockController::ThreadPool()
Add FileIO::FileIO()
Add FileIO::{At(), Get(), Put(), ::BlockController::{Checkpoint(), Recovery()}}; Modify FileIO::BlockController::InitializeFileIo()
Add FileIO::Merge()
Roughly finish ExtraFileController
Pass the test
Add lock for FileIO
Remove InterlockedCompareExchange and fix ThreadPool timer
Try mem cache
Fixed bugs in mem cache
Remove log for mem cache
Debug version
Add Debug function
Fix bug in AddPages
modify ShutDown
Modify create file
Fix bug in ShutDown
Add monitor thread
Add Async IO
Fix bugs in IOStatistics
pre alloc iocb
Remove ThreadPool
Add KeyValueTest
Modify KeyValueTest
Finish KeyValueTest
Add Conflicting test
Add Merge test
Add timeout
Add new functions
Add FileIOInterface
Fix bugs in io setup
Remove useless statement
Add new apii
Add new api
Remove useless code
Add Scan
Add Write Cache (Still has bugs)
Modify implementation of LRUCache
Add Sharded LRU Cache
Modify IOStatistics
* fix LoadIndex and FileIO BuildIndex
* fix thread_local variable does not init
* fix read
* reclean the logs
* add Script_AE
* fix build and search
* fix build + search
* fix compelling, temporarily remove virtual function in IExtraSearch.h
* fix segementation fault at searching
* fix compelling & add condition to include RocksDB & SPDK
---------
Co-authored-by: MaggieQi <chenqi871025@gmail.com>
Co-authored-by: Qi Chen <cheqi@microsoft.com>
* merge AsyncFileReader and FileIO
* fix Linux compiling
* just backup
* fix conflict with marco and Storage type
* fix the compiling and runtime error
* update log
* add unit test for spfresh
* fix compiling
* update test
* fix the search issue
* add allfinish checking
* add insert support
* fix alloc and free mismatch
* fix Clone and threadpool position in SPANN::Index
* fix Save and Load Crash issue
* fix read and write inifite loop issue
* fix AlgoTest
* fix iocp issue and iterator issue
* add more log to see the shutdown issue
* remove som statistice vectors
* fix a small memory leak
* fix readblocks issue
* add debug info
* fix addindex issue
* add more debug information
* merge file expansion
* fix the Linux testing
* make the unittest faster with small StartFileSizeGB
* fix merge exceed limit issue
* fix append split loop issue
* fix iterative search test
* Clean all the Initialize and ExitBlockController
* Remove all the Initialize and ExitBlockController
* remove all the ExitBlockController
* fix compiling issue for SPDKIO
* fix FileIOInterface
* fix FileIOInterface
* Add Windows SPFresh support
* speedup the file compare
* Spfresh windows (#426)
* fix excludehead
* fix RocksDB slice reference issue
* fix writeBlock bug & expand file log error(GB size)
* fix SPDKIO: temorarily replace RequestQueue
* fix SPDK read write and also the posting page limit
* fix compiling issue in linux
* move aio related definition to AsyncFileReader
* upgrade to vc143 for windows
* remove timeout break
* clear the index intime
* clean test index dir
* add buffer size into page buffer
* fix testcases
* recover PageSize in linux readbatch
* Changing clone to class member instead. (#427)
* move SPANN clone to VectorIndex
* format all files
* fix SPANNIndex compiling issue
* add warning logs and configuration for io threads.
* add guardian client
* change exit() to ErrorCode
* fix azure pipeline post analysis issues
* fix the azure pipeline warnings and errors
* add retry and error handling in SearchIndexWithoutParsing
* fix BKT Iterative Search
* add errorcode for iterator
* Fix Checkpoint block merge issue
* add RefineIndex and IterativeSearch test cases
* fix linux compiling for spfresh
* fix SPANN iterator scanned count
* fix page limit in iterativetest
* fix CombineVectorSets
* fix read delete entry
* fix truth generation
* delay remove to get higher recall
* fix RefineIndex
* add more disk info
* fix error propagation, infiniteloop and KDTTest issue
* fix linux compiling issue.
* fix TestLoadandSave metadata issue
* fix IterativeScanTest
* Adding check to avoid crash
* reclaimmemory
* return false when read/write blocks number is less than required.
* fix global workspace id issue
* fix compiling warning
* fix RefineIndex dataset reuse issue
* add extraSearcher available check before loadindex and buildindex
* add Perf test
* Add Filter in Iterator
* fix compiling issue
* fix WorkSpace functional header
* fix AlgoTest
* add more log and error handler
* fix PostingSize < 0 issue and lock issue
* change all openmp to normal thread
* fix linux compiling
* try to fix BKTTest issue
* fix postingSize < 0 issue
* Add ConsistencyCheck
* Returning success (#433)
* Add Check in IterativeSearchPerf Test.
* fix the postingSize check
* Add Checksum Support
* add onecluster cut configuration, remove BKT check, and add BKT rebuild
* fix Static Index Save
* Disable Split and Reassgn get checksum check
* add RefineIndex Check
* fix RefineIndex and add large insert test
* add more log for one cluster
* add OneCluster configuration
* fix datatype
* fix dimension
* add size check for each put and merge operation
* remove global mt random
* fix refine issue
* add check right after put in split
* set both consistency check and checksum check configurable
* fix write error block or blockmapping leak issue
* fix Debug BKT Clustering atomic add issue
* fix the add perf
* adjust the destroy order
* Revert "fix Debug BKT Clustering atomic add issue"
This reverts commit 03f051e.
* add checksumInRead configuation
* add mutable comments
* provide distance convert between distance and cosine similarity
* fix head global VID deleted issue
* add check for deleted and dup.
* add write cache
* Add Test for Cache
* fix SPFreshTest compiling issue
* fix lock issue in cache
* fix merge/get deadlock issue
* fix cache string size
* fix get size issue
* Fix compacted ID mapping in SPFresh
* maxsize special case
* revert macro
* fix size in get to avoid conflict
* add append reorder
* fix reorder append compiling issue
* Add zeroreplica vectors in the end of buildindex
* fix vectorTranslateMap empty in BuildIndex
* fix Dataset Load
* fix Windows compiling issues
* add io_uring support
* fix CMakeLists.txt typo
* fix global workspace destoy issue
* fix io uring compiling
* fix writecache issue
* fix iterative search in BKT to avoid dup results
* relax postingSize limit in buildindex
* enable merge
* fix write cache lock and double free issue.
* add RefineIndex Error return
* optimize relaxed mono setting condition
* fix compiling and add more checksum check
* modify the iteratorSearch test cases to remove the resultCount check.
---------
Co-authored-by: Hengyu Liang <lhy1210302421@mail.ustc.edu.cn>
Co-authored-by: Yuming-Xu <xuyuming@mail.ustc.edu.cn>
Co-authored-by: Hengyu Liang <lhy_ustc@mail.ustc.edu.cn>
Co-authored-by: lml <liml@mail.ustc.edu.cn>
Co-authored-by: Qi Chen <cheqi@microsoft.com>
Co-authored-by: Yuming-Xu <56633988+Yuming-Xu@users.noreply.github.com>
Co-authored-by: Avinash <bnavarma@gmail.com>
Co-authored-by: Philip Adams <35666630+PhilipBAdams@users.noreply.github.com>
Co-authored-by: Philip Adams <philipadams@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.