Skip to content

Refactor read trace invocation to avoid duplicate calls to post import script and to exclude log_NNN.trc files #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PiJoCoder merged 6 commits into from
Nov 20, 2025
Merged

Refactor read trace invocation to avoid duplicate calls to post import script and to exclude log_NNN.trc files #471

PiJoCoder merged 6 commits into from
Nov 20, 2025

Conversation

@PiJoCoder
Copy link
Collaborator

@PiJoCoder PiJoCoder commented Nov 14, 2025 •
edited
Loading

How to test:

  1. Collect a GeneralPerf trace with SQL LogScout (current dev builds). This should include default trace files log_*.trc
  2. Make sure to run a few queries against the SQL Server that you are capturing from to cause some .XEL events to be captured
  3. Run an import of the \output folder
  4. Look for a message like this in the SQLNexus log
    SQLNexus Information: 0 : Excluded 5 trace file(s) from import based on exclusion criteria (log_NNN.trc / *_blk.trc).
  5. Also search for this message in the log. You should find only one for the XEL import. Prior to this fix, there were multiple for each type of importer.
    Executing post-script: ReadTracePostProcessing.sql

@PiJoCoder PiJoCoder changed the title Refactor read trace invokation Refactor read trace invocation to avoid duplicate calls to post import script Nov 14, 2025
@PiJoCoder PiJoCoder changed the title Refactor read trace invocation to avoid duplicate calls to post import script Refactor read trace invocation to avoid duplicate calls to post import script and to exclude log_NNN.trc files Nov 20, 2025
@PiJoCoder PiJoCoder merged commit 105bbca into master Nov 20, 2025
3 checks passed
@PiJoCoder PiJoCoder deleted the RefactorReadTraceInvokation_pijocoder111325 branch November 20, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hacitandogan hacitandogan hacitandogan approved these changes

@asavioliMSFT asavioliMSFT Awaiting requested review from asavioliMSFT

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PiJoCoder @hacitandogan