-
Notifications
You must be signed in to change notification settings - Fork 459
Migrate 10 removed dictionaries #2294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bashamega
wants to merge
8
commits into
microsoft:main
Choose a base branch
from
Bashamega:migrate-dictionaries-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c227f8a
Migrate 10 removed dictionaries
Bashamega c678a68
Merge branch 'main' into migrate-dictionaries-2
Bashamega 1204b68
Adds spaces
Bashamega 98628b2
Add comments for aac and flac members in AudioEncoderConfig
saschanaz e7449dc
transform web animation instead of css
Bashamega ac9e857
Merge branch 'migrate-dictionaries-2' of https://github.com/Bashamega…
Bashamega 129d14a
-
Bashamega 74cb4c8
Merge branch 'main' into migrate-dictionaries-2
Bashamega File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| removals { | ||
| dictionary CredentialCreationOptions { | ||
| member digital // Blink test-only as of 2025-05 | ||
| member federated // Blink only as of 2025-05 | ||
| member password // Blink only as of 2025-05 | ||
| member mediation // WebKit only as of 2025-05 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| removals { | ||
| dictionary DisplayMediaStreamOptions { | ||
| // Only `audio` and `video` are implemented by 2+ engines, everything else is currently Blink only. | ||
| // https://searchfox.org/mozilla-central/source/dom/webidl/MediaStream.webidl | ||
| // https://searchfox.org/wubkat/source/Source/WebCore/Modules/mediastream/MediaDevices.idl | ||
| // https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/node_modules/@webref/idl/screen-capture.idl | ||
| member monitorTypeSurfaces | ||
| member selfBrowserSurface | ||
| member surfaceSwitching | ||
| member systemAudio | ||
| member windowAudio | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| removals { | ||
| dictionary FetchEventInit { | ||
| member replacesClientId // Not implemented as of 2025-04 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| removals { | ||
| dictionary GetAnimationsOptions { | ||
| member pseudoElement // No implementation as of 2024-11 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| removals { | ||
| dictionary AudioContextOptions { | ||
| member renderSizeHint // No implementation as of 2023-10 | ||
| member sinkId // Blink only as of 2023-10 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in WebKit in 2024 and Blink a few weeks ago 👀 Want to have another PR?