.NET: MemoryCacheExtensions semaphore pooling #3043
+5
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The current
MemoryCacheExtensionsallocates a SemaphoreSlim object every timeGetOrCreateAtomicAsyncis called on an object that is not currently in the memory cache. We can reduce memory allocations through pooling.Description
The solution uses the battle-tested AsyncKeyedLock library (note: I am the author of this library), which is already used in Microsoft projects such as Kiota and Vipr and has also been used in situations to prevent cache stampede (e.g. FusionCache) and in important projects such as ABP Framework.
Contribution Checklist