Skip to content

Conversation

@dobesv
Copy link

@dobesv dobesv commented May 7, 2025

Add support for cache storage to AWS S3.

Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, but most of the current users of lage/backfill won't want a tree of AWS dependencies pulled in by default.

An alternative would be to specify the AWS deps as peerDependencies that are marked as optional in peerDependenciesMeta (and update the provider to throw if the dep isn't present). The peer deps would need to be specified in both the backfill-cache and backfill packages.

Also, due to the potentially-missing dependency and the way lage's types rollup works, it would be best to avoid directly references the types in backfill-config--so clientConfig?: object in S3CacheStorageOptions.

@dobesv
Copy link
Author

dobesv commented Aug 9, 2025

  • I moved the shared Azure/S3 classes to their own files so they can be shared between those two backends.
  • I changed the types in config so they don't need to reference the aws-sdk package types

@dobesv dobesv requested a review from ecraig12345 August 9, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants