feat: Added main.waf.parameters.json with updated parameters and updated deployment.md with waf deployment steps #697
Open
Kanchan-Microsoft wants to merge 2 commits intodevfrom
Open
feat: Added main.waf.parameters.json with updated parameters and updated deployment.md with waf deployment steps #697Kanchan-Microsoft wants to merge 2 commits intodevfrom
Kanchan-Microsoft wants to merge 2 commits intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request adds improved documentation and configuration options for deploying the Content Generation Solution Accelerator, with a focus on distinguishing between sandbox/dev and production environments. It introduces a new production-ready parameters file aligned with the Well-Architected Framework (WAF), updates deployment instructions, and clarifies parameter usage for different environments.
Deployment Documentation Improvements:
DEPLOYMENT.md, explaining the use of the default sandbox (main.parameters.json) and new production (main.waf.parameters.json) parameter files, and providing step-by-step instructions for switching between them.Production Configuration Support:
main.waf.parameters.json, a production-ready parameters file with WAF-aligned settings, including enabled monitoring, private networking, and scalability options, as well as required VM admin credentials.Sandbox/Dev Configuration Adjustments:
enablePrivateNetworking,enableMonitoring,enableScalability, andenableRedundancyparameters frommain.parameters.jsonto simplify the sandbox/dev configuration and reduce potential confusion between environments.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information