Feat/expand chart support #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for two new chart types—Pie Chart and US Map with Points—expanding the visualization capabilities of the application. Both templates follow the established pattern used by existing chart templates, with appropriate channel definitions, path mappings, and MUI icon integrations.
Key Changes:
- Added Pie Chart template with support for theta, color, and faceting channels
- Added US Map with Points template with geographic projections and point overlay
- Registered both templates in the CHART_TEMPLATES export
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
I loved it! It looks fun 
|
Collaborator
|
the map one also works perfectly, thanks for the work! Might worth in future to consider how to design generic maps with some parameters 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #193
Added two new chart templates — Pie Chart and US Map with Points — and registers them in
src/components/ChartTemplates.tsx. Both templates include placeholder MUI icons, channel wiring, and integration intoCHART_TEMPLATES.Pie Chart
arcmark with straightforward defaults.US Map (States + Points)
longitude/latitude, with optional color and size channels.Notes / Caveats
https://vega.github.io/vega-lite/data/us-10m.json