Skip to content

Allow colon in ACE subject name to support repo URIs #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasongin merged 1 commit into from
Jan 9, 2026
Merged

Allow colon in ACE subject name to support repo URIs #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cs/src/Contracts/TunnelConstraints.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ public static class TunnelConstraints
/// formatted name with email. The service will block any other use of angle-brackets,
/// to avoid any XSS risks.
/// </remarks>
public const string AccessControlSubjectNamePattern = "[ \\w\\d-.,/'\"_@()<>]{0,200}";
public const string AccessControlSubjectNamePattern = "[ \\w\\d-.,/:'\"_@()<>]{0,200}";

/// <summary>
/// Regular expression that can match or validate an access control subject name, when resolving
Expand Down
2 changes: 1 addition & 1 deletion go/tunnels/tunnel_constraints.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ const (
// Note angle-brackets are only allowed when they wrap an email address as part of a
// formatted name with email. The service will block any other use of angle-brackets, to
// avoid any XSS risks.
TunnelConstraintsAccessControlSubjectNamePattern = "[ \\w\\d-.,/'\"_@()<>]{0,200}"
TunnelConstraintsAccessControlSubjectNamePattern = "[ \\w\\d-.,/:'\"_@()<>]{0,200}"
)
var (
// Regular expression that can match or validate tunnel cluster ID strings.
Expand Down
2 changes: 1 addition & 1 deletion java/src/main/java/com/microsoft/tunnels/contracts/TunnelConstraints.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ public class TunnelConstraints {
* formatted name with email. The service will block any other use of angle-brackets,
* to avoid any XSS risks.
*/
public static final String accessControlSubjectNamePattern = "[ \\w\\d-.,/'\"_@()<>]{0,200}";
public static final String accessControlSubjectNamePattern = "[ \\w\\d-.,/:'\"_@()<>]{0,200}";

/**
* Regular expression that can match or validate an access control subject name, when
Expand Down
2 changes: 1 addition & 1 deletion rs/src/contracts/tunnel_constraints.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,4 +150,4 @@ pub const ACCESS_CONTROL_SUBJECT_PATTERN: &str = r#"[0-9a-zA-Z-._:/@]{0,200}"#;
// Note angle-brackets are only allowed when they wrap an email address as part of a
// formatted name with email. The service will block any other use of angle-brackets, to
// avoid any XSS risks.
pub const ACCESS_CONTROL_SUBJECT_NAME_PATTERN: &str = r#"[ \w\d-.,/'"_@()<>]{0,200}"#;
pub const ACCESS_CONTROL_SUBJECT_NAME_PATTERN: &str = r#"[ \w\d-.,/:'"_@()<>]{0,200}"#;
2 changes: 1 addition & 1 deletion ts/src/contracts/tunnelConstraints.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ export namespace TunnelConstraints {
* formatted name with email. The service will block any other use of angle-brackets,
* to avoid any XSS risks.
*/
export const accessControlSubjectNamePattern: string = '[ \\w\\d-.,/\'"_@()<>]{0,200}';
export const accessControlSubjectNamePattern: string = '[ \\w\\d-.,/:\'"_@()<>]{0,200}';

/**
* Regular expression that can match or validate an access control subject name, when
Expand Down
Loading