-
Notifications
You must be signed in to change notification settings - Fork 16
Convert code-mirror.yml to 1ES Official Pipeline Template #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>
|
@copilot Encountered error(s) while parsing pipeline YAML: |
Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>
Fixed in ff6bb39. Changed the repository alias from |
|
@torosent do you know why this is change is being made? code-mirror extends 1ESPT already: https://dev.azure.com/azfunc/internal/_git/engineering?path=/ci/code-mirror.yml. And we want unofficial here, the code-mirror pipeline should be marked as non-production. If it isn't non-production, you can change it to non-prod via product catalog if you are a service admin. https://aka.ms/productcatalog |
SFI. This was marked as production |
jviau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not how code-mirror is intended to be used. I'd like to understand what motivated this change.
Issue describing the changes in this PR
Migrates
eng/ci/code-mirror.ymlfrom legacy template to 1ES Official Pipeline Template format, matching the structure ofofficial-build.yml.Pull request checklist
CHANGELOG.mdAdditional information
Changes:
1ESPipelineTemplates/1ESPipelineTemplatesrepository reference with alias1ESPipelineTemplates(instead of1es) to avoid repository alias conflicts with the referencedci/code-mirror.yml@engtemplateci/code-mirror.yml@engtov1/1ES.Official.PipelineTemplate.yml@1ESPipelineTemplates1es-pool-azfuncwith Windows 2022 imagepr: nonetrigger exclusionThe pipeline maintains its original code mirroring functionality while now operating within the Microsoft 1ES security and compliance framework. The use of
1ESPipelineTemplatesas the repository alias follows the pattern established inrelease.ymland prevents conflicts when the pipeline references external engineering templates.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.