Use the trait instead of bare process_vm_readv
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `process_vm_readv` syscall might not be available on some systems due to the age or being disabled in the kernel configuration. The `get_va_regions` function uses it without unconditionally. Use the `ReadProcessMmeory` trait instead to abstract these deatils away and fix older systems and systems with a custom kernel configurations disabling the `process_vm_readv` call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
process_vm_readvsyscall might not be available on some systems due to the age or being disabled in the kernel configuration. Theget_va_regionsfunction uses it unconditionally.Use the
ReadProcessMmeorytrait instead to abstract these deatils away and fix older systems and systems with a custom kernel configurations disabling theprocess_vm_readvcall.