chore(react-utilities): improve Slot signature to be more presentable in Storybook#31636
Draft
bsunderhus wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 67 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 609 | 623 | 5000 | |
| Button | mount | 297 | 297 | 5000 | |
| Field | mount | 1152 | 1126 | 5000 | |
| FluentProvider | mount | 719 | 708 | 5000 | |
| FluentProviderWithTheme | mount | 91 | 88 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 34 | 33 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 67 | 10 | Possible regression |
| MakeStyles | mount | 845 | 846 | 50000 | |
| Persona | mount | 1728 | 1747 | 5000 | |
| SpinButton | mount | 1412 | 1363 | 5000 | |
| SwatchPicker | mount | 1524 | 1505 | 5000 |
Collaborator
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jun 10, 2024
change/@fluentui-react-utilities-7013f126-ca0d-4752-b4a9-e9d912be491a.json
Show resolved
Hide resolved
2cba23e to
f9ed3eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Slotsignature gets broken into its type equivalence by TS compiler (more info #27105 (comment)):New Behavior
Modifies
Slotsignature to be more presentable on Storybook's docgen extraction.Problems involved with this Solution
We verify if the first generic provided to
Slot<T>is a singleton value (a value that is not an union of other values). This PR modifies this signature to be internal to another type (SlotProps), as this type verification is one of the causes of whySlotsignature ends up being processed by TS compiler the way it does.Previously if someone would provide a union we'd have:
By moving the singleton verification down to another type (
SlotProps) we'll be allowing some types in situations they should probably not be allowed, in this case in particular is not so problematic as we're only allowingnull:Related Issue(s)
Slot<T>type #27105