chore: Update react-icons package to latest version (2.0.271)#33755
Open
tomi-msft wants to merge 4 commits intomicrosoft:masterfrom
Open
chore: Update react-icons package to latest version (2.0.271)#33755tomi-msft wants to merge 4 commits intomicrosoft:masterfrom
2.0.271)#33755tomi-msft wants to merge 4 commits intomicrosoft:masterfrom
Conversation
tomi-msft
requested review from
a team,
GeoffCoxMSFT,
Mitch-At-Work,
khmakoto,
mltejera,
ms-acalzaretto and
sopranopillow
as code owners
khmakoto
changed the title
2.0.271)
khmakoto
modified the milestones:
April Project Cycle Q1 2024,
January Project Cycle Q1 2025
khmakoto
previously approved these changes
Jan 31, 2025
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Jan 31, 2025
| @@ -35,7 +35,7 @@ | |||
| "@fluentui/react-divider": "*", | |||
Collaborator
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-AreaChart.Custom Accessibility.chromium.png | 11 | Changed |
react-charting-VerticalBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-VerticalBarChart.Basic - Secondary Y Axis.chromium.png | 4 | Changed |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Jan 31, 2025
| @@ -35,7 +35,7 @@ | |||
| "@fluentui/react-divider": "*", | |||
Collaborator
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.Badge Mask RTL.chromium.png | 5 | Changed |
khmakoto
reviewed
Jan 31, 2025
Hotell
reviewed
Feb 6, 2025
Contributor
There was a problem hiding this comment.
pipelines are failing in 2 places which relate to each other
-
you need to dedupe
-
because you didnt dedupe the docsite v9 wants to bundle 2 fluent icons packages which explodes ( memory leak )
- my hopes are that this will be mitigated once deduped, if not there is some critical regression on icons package which needs to be resolved prior to merge this .
ty
github-actions
bot
modified the milestones:
January Project Cycle Q1 2025,
February Project Cycle Q1 2025
Collaborator
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the version of
@fluentui/react-iconsin the project from2.0.245to2.0.271. This is a minor change that will pick up new icons added by design into the Icons Catalog.