Fix problem with loading css/scsss #511
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As long as the `localIdentName` was set in the parameter the modules parameter was ignored. This resulted in the use of modules even when modules was set to false explicitly
ecraig12345
approved these changes
Jan 27, 2021
Member
ecraig12345
left a comment
ecraig12345
left a comment
There was a problem hiding this comment.
Thanks for doing this! You'll also need to run yarn change to generate a change file.
Author
|
@ecraig12345 is it possible to crate this file manual? |
Member
|
@LokiMidgard Maybe, but it would probably be easier to just clone the repo, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as the
localIdentNamewas set in the parameter the modules parameter was ignored. This resulted in the use of modules even when modules was set to false explicitlyOverview
Fixes #343
The problem was introduced in #243. It fixed a problem with invalid options, but always set the module option for the css-loader.
This prevented the styles to get applied since the name of the style was changed in the css but not in the DOM.
Test Notes