Remove just-scripts-utils and just-task-logger packages #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
commented
Mar 10, 2023
| const { mockExecFactory } = require('./mockExecFactory'); | ||
| return mockExecFactory(); | ||
| jest.mock('../../utils', () => { | ||
| const originalModule = jest.requireActual('../../utils'); |
Member
Author
There was a problem hiding this comment.
This was moved from the mockExecFactory file (which was very simple and only used in one place)
Comment on lines
-2
to
-4
| export * from './interfaces/PackageJson'; | ||
| export * from './interfaces/RushJson'; | ||
| export * from './logger'; |
Member
Author
There was a problem hiding this comment.
- PackageJson was moved to a different location, not under the utils folder
- RushJson types are removed: they weren't used anywhere, and weren't re-exported from
just-scripts - This was a re-export of the logger package which is now redundant
| @@ -1 +1,85 @@ | |||
| export * from 'just-task-logger'; | |||
| import chalk = require('chalk'); | |||
Member
Author
There was a problem hiding this comment.
This is NOT new code, just a move/merge of the files just-task-logger/src/logger.ts and just-task-logger/src/mark.ts (the mark file was small, so it was easier to just consolidate them)
ecraig12345
force-pushed
the
ecraig/remove-utils
branch
from
6251cc2 to
e8e6520
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally
just-scripts-utilsandjust-task-loggerwere used by multiple packages in the Just family (such as for repo creation and management), but now that the focus of Just has been narrowed to task orchestration, those utils are only directly used in one package each.This PR merges
just-scripts-utilsintojust-scripts, andjust-task-loggerintojust-task. This simplifies the repo setup and reduces maintenance overhead a bit.Based on internal usage, the following new exports were added to replace those from the util packages:
just-scripts:encodeArgs