Fix deserialization of List<Double> in JSON parse node#2025
Merged
baywet merged 2 commits intomicrosoft:mainfrom Sep 8, 2025
Merged
Conversation
This fixes the inability to deserialize collections of Doubles
Contributor
Author
|
@microsoft-github-policy-service agree company="Citrine Informatics" |
Contributor
Author
Thanks for the timely review and release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix deserialization of
List<Double>in JSON parse nodeSummary
Adds support for
java.lang.Doublein JSON primitive value parsing, fixing failures when deserializing collections of doubles. Includes a unit test validating getCollectionOfPrimitiveValues(Double.class).Motivation
Collections of Double values could not be deserialized because JsonParseNode.getPrimitiveValue lacked a
Double.classbranch. This broke scenarios parsing arrays like [1.1, 2.2, 3.3], including on kiota-generated model classes that contain lists of doubles.Changes
Double.classingetPrimitiveValueby delegating togetDoubleValue()inJsonParseNodeTestsjava.lang.RuntimeException: unknown type to deserialize java.lang.Double