Verify making a post in Python configuring the headers#3962
Draft
andreaTP wants to merge 1 commit intomicrosoft:mainfrom
Draft
Verify making a post in Python configuring the headers#3962andreaTP wants to merge 1 commit intomicrosoft:mainfrom
andreaTP wants to merge 1 commit intomicrosoft:mainfrom
Conversation
andreaTP
commented
Jan 2, 2024
| request_adapter.base_url = 'http://127.0.0.1:1080' | ||
| client = ApiClient(request_adapter) | ||
|
|
||
| myHeaders = HeadersCollection() |
Contributor
Author
There was a problem hiding this comment.
This is the nasty detail, it looks like a lot of boilerplate for something that we used to write as:
config = TodosRequestBuilder.TodosRequestBuilderPostRequestConfiguration(
headers = { "My-Extra-Header", "hello" }
)Either we add more helper methods to make the conversion automatic for the user or, at the very least, we should add a constructor from Dict[str, str | List[str]] to HeadersCollection.
What do you think?
Member
There was a problem hiding this comment.
for context to others reading this. It's being discussed here microsoft/kiota-python#208
This was referenced Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this as PR as it adds to coverage, but the intention is to focus on the
HeadersCollectionimplementation.