Conversation
Fix discriminator keys for oneOf with allOf-inherited types GetDiscriminatorMappings() now resolves OpenApiSchemaReference in allOf to find base type discriminator mappings, instead of falling back to using schema names as keys.
Contributor
Author
|
@microsoft-github-policy-service agree |
baywet
requested changes
Jan 30, 2026
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Can you please add a changelog entry unreleased/changed?
Contributor
Author
sure, i have added this |
baywet
approved these changes
Feb 2, 2026
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix discriminator keys for oneOf with allOf-inherited types
GetDiscriminatorMappings() now resolves OpenApiSchemaReference in allOf to find base type discriminator mappings, instead of falling back to using schema names as keys.