Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
1475fc5
beginning to do ts-fix
kenotron Jan 15, 2025
a756283
fixing up the logger ts
kenotron Jan 15, 2025
b3edd68
add return types to format-hrtime package
kenotron Jan 15, 2025
89e748c
fixing globby
kenotron Jan 15, 2025
15c151d
cannot have both allowJs and isolatedDecl at the same time
kenotron Jan 15, 2025
2db9ff3
return types added for monorepo-fixture
kenotron Jan 15, 2025
80e4ddc
adding return types to target-graph
kenotron Jan 15, 2025
e9d9e39
fixing up target-graph and rpc packages
kenotron Jan 15, 2025
59ee2e6
updates to rpc
kenotron Jan 15, 2025
e7cf412
adding return types to runners
kenotron Jan 15, 2025
b61a175
adding return types to cache
kenotron Jan 15, 2025
e98963f
fix config
kenotron Jan 15, 2025
f9e6632
fix backfill wrapper for cache
kenotron Jan 15, 2025
3345154
reporters fix
kenotron Jan 15, 2025
3c51093
rpc
kenotron Jan 15, 2025
15332ec
fixing globby
kenotron Jan 15, 2025
40a186d
fixing hasher
kenotron Jan 15, 2025
673566e
scheduler
kenotron Jan 15, 2025
3264dae
worker-threads-pool
kenotron Jan 15, 2025
cd2b8a2
adding arg types
kenotron Jan 15, 2025
01e0515
fix CLI package
kenotron Jan 15, 2025
8710448
fixing up e2e-tests
kenotron Jan 15, 2025
ecd4800
Change files
kenotron Jan 15, 2025
981ebcd
updated swc and enabled emitIsolatedDts with swc
kenotron Jan 15, 2025
cfdfd31
adding experimentals
kenotron Jan 15, 2025
05b13d1
type checking works!
kenotron Jan 15, 2025
b1788a2
Merge remote-tracking branch 'origin/master' into isolated-declarations
kenotron Jan 17, 2025
dd71194
fixing for prettier
kenotron Jan 17, 2025
8bacfd5
Change files
kenotron Jan 18, 2025
919dfbd
Merge branch 'master' into isolated-declarations
kenotron Jan 30, 2025
83accde
fixed a couple of goobers from ts-fix
kenotron Jan 30, 2025
eb51cf2
Merge branch 'master' into isolated-declarations
kenotron Jan 30, 2025
8f8ea31
Merge branch 'master' into isolated-declarations
kenotron Feb 6, 2025
bd0dae1
fixing up isolated declaration errors
kenotron Feb 6, 2025
b8ff771
fixing some linting and isodeclarations issues
kenotron Feb 6, 2025
c469ec4
fixed outputs config in lage.config.js
kenotron Feb 26, 2025
aa45692
weird image diff
ecraig12345 Jan 24, 2026
91e5584
Merge branch 'master' into isolated-declarations
ecraig12345 Jan 24, 2026
7b2109b
revert docs
ecraig12345 Jan 24, 2026
1b22a1c
oops
ecraig12345 Jan 24, 2026
9af260a
cleanup
ecraig12345 Jan 24, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .swcrc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
"tsx": false,
"dynamicImport": true
},
"target": "es2020"
"target": "es2020",
"experimental": {
"emitIsolatedDts": true
}
},
"module": {
"type": "commonjs",
Expand Down
18 changes: 18 additions & 0 deletions change/change-4d116d1c-68e7-4744-ac24-707e35ddd69f.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"changes": [
{
"type": "patch",
"comment": "isolated declarations",
"packageName": "@lage-run/cache-github-actions",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
},
{
"type": "patch",
"comment": "isolated declarations",
"packageName": "@lage-run/scheduler-types",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
}
]
}
95 changes: 95 additions & 0 deletions change/change-7f40e1b3-256a-42a3-a306-4cc681250ece.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
{
"changes": [
{
"type": "patch",
"comment": "Adding isolated-declarations flag everywhere",
"packageName": "@lage-run/cache",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
},
{
"type": "patch",
"comment": "Adding isolated-declarations flag everywhere",
"packageName": "@lage-run/cli",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
},
{
"type": "patch",
"comment": "Adding isolated-declarations flag everywhere",
"packageName": "@lage-run/config",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
},
{
"type": "patch",
"comment": "Adding isolated-declarations flag everywhere",
"packageName": "@lage-run/format-hrtime",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
},
{
"type": "patch",
"comment": "Adding isolated-declarations flag everywhere",
"packageName": "@lage-run/globby",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
},
{
"type": "patch",
"comment": "Adding isolated-declarations flag everywhere",
"packageName": "@lage-run/hasher",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
},
{
"type": "patch",
"comment": "Adding isolated-declarations flag everywhere",
"packageName": "@lage-run/logger",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
},
{
"type": "patch",
"comment": "Adding isolated-declarations flag everywhere",
"packageName": "@lage-run/reporters",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
},
{
"type": "patch",
"comment": "Adding isolated-declarations flag everywhere",
"packageName": "@lage-run/rpc",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
},
{
"type": "patch",
"comment": "Adding isolated-declarations flag everywhere",
"packageName": "@lage-run/runners",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
},
{
"type": "patch",
"comment": "Adding isolated-declarations flag everywhere",
"packageName": "@lage-run/scheduler",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
},
{
"type": "patch",
"comment": "Adding isolated-declarations flag everywhere",
"packageName": "@lage-run/target-graph",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
},
{
"type": "patch",
"comment": "Adding isolated-declarations flag everywhere",
"packageName": "@lage-run/worker-threads-pool",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch"
}
]
}
11 changes: 4 additions & 7 deletions lage.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,9 @@ module.exports = {
pipeline: {
"lage#bundle": ["^^transpile", "types"],
types: {
type: "worker",
options: {
worker: path.join(__dirname, "scripts/worker/types.js"),
},
dependsOn: ["^types"],
outputs: ["lib/**/*.d.ts"],
type: "npmScript",
dependsOn: ["^^transpile"],
outputs: [],
},
isolatedTypes: {
type: "worker",
Expand All @@ -27,7 +24,7 @@ module.exports = {
options: {
worker: path.join(__dirname, "scripts/worker/transpile.js"),
},
outputs: ["lib/**/*.js"],
outputs: ["lib/**/*.js", "lib/**/*.map", "lib/**/*.d.ts"],
},
test: {
type: "worker",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"scripts": {
"build": "lage transpile types build bundle",
"watch": "lage transpile isolatedTypes --no-cache --verbose --unstable-watch",
"watch": "lage transpile types --no-cache --verbose --unstable-watch",
"change": "beachball change",
"checkchange": "beachball check",
"ci": "lage transpile types build test lint bundle",
Expand Down
3 changes: 2 additions & 1 deletion packages/cache-github-actions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"scripts": {
"build": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"lint": "monorepo-scripts lint"
"lint": "monorepo-scripts lint",
"types": "monorepo-scripts tsc"
},
"dependencies": {
"@actions/cache": "3.3.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/cache/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"build": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
"lint": "monorepo-scripts lint",
"types": "monorepo-scripts tsc"
},
"dependencies": {
"@azure/core-auth": "1.10.1",
Expand Down
8 changes: 4 additions & 4 deletions packages/cache/src/backfillWrapper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*/

import * as os from "os";
import { type Config, createDefaultConfig, getEnvConfig } from "backfill-config";
import { createDefaultConfig, getEnvConfig } from "backfill-config";
import { makeLogger } from "backfill-logger";
import type { Logger as BackfillLogger } from "backfill-logger";
import type { CacheOptions } from "@lage-run/config";
Expand Down Expand Up @@ -32,15 +32,15 @@ export function createBackfillCacheConfig(
cwd: string,
cacheOptions: Partial<CacheOptions> | undefined = {},
backfillLogger: BackfillLogger
): Config {
): CacheOptions {
const envConfig = getEnvConfig(backfillLogger);
const mergedConfig = {
...createDefaultConfig(cwd),
...cacheOptions,
...envConfig,
} as Config;
} as CacheOptions;

if (mergedConfig.cacheStorageConfig.provider === "azure-blob") {
if (mergedConfig.cacheStorageConfig?.provider === "azure-blob") {
const azureOptions = mergedConfig.cacheStorageConfig.options;
if ("connectionString" in azureOptions && !isTokenConnectionString(azureOptions.connectionString)) {
/** Pass through optional credentialName from config to select a specific credential implementation
Expand Down
5 changes: 3 additions & 2 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@
"main": "lib/index.js",
"types": "lib/index.d.ts",
"scripts": {
"build": "tsc",
"start": "tsc -w --preserveWatchOutput",
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
},
Expand Down
7 changes: 4 additions & 3 deletions packages/config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@
"main": "lib/index.js",
"types": "lib/index.d.ts",
"scripts": {
"build": "tsc",
"start": "tsc -w --preserveWatchOutput",
"test": "jest",
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
},
"dependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/e2e-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@
"main": "lib/index.js",
"types": "lib/index.d.ts",
"scripts": {
"build": "tsc",
"start": "tsc -w --preserveWatchOutput",
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
},
Expand Down
7 changes: 4 additions & 3 deletions packages/format-hrtime/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@
"main": "lib/index.js",
"types": "lib/index.d.ts",
"scripts": {
"build": "tsc",
"start": "tsc -w --preserveWatchOutput",
"test": "jest",
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
},
"devDependencies": {
Expand Down
1 change: 0 additions & 1 deletion packages/globby/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"extends": "../tsconfig.lage2.json",
"compilerOptions": {
"outDir": "./lib",
"emitDeclarationOnly": true,
"module": "Node16",
"moduleResolution": "Node16",
"lib": ["ES2020"]
Expand Down
5 changes: 3 additions & 2 deletions packages/hasher/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@
"main": "lib/index.js",
"types": "lib/index.d.ts",
"scripts": {
"build": "tsc",
"start": "tsc -w --preserveWatchOutput",
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
},
Expand Down
7 changes: 4 additions & 3 deletions packages/logger/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@
"main": "lib/index.js",
"types": "lib/index.d.ts",
"scripts": {
"build": "tsc",
"start": "tsc -w --preserveWatchOutput",
"test": "jest",
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
},
"devDependencies": {
Expand Down
6 changes: 4 additions & 2 deletions packages/monorepo-fixture/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@
"main": "lib/index.js",
"types": "lib/index.d.ts",
"scripts": {
"build": "tsc",
"start": "tsc -w --preserveWatchOutput",
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
},
"devDependencies": {
Expand Down
7 changes: 4 additions & 3 deletions packages/reporters/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@
"main": "lib/index.js",
"types": "lib/index.d.ts",
"scripts": {
"build": "tsc",
"start": "tsc -w --preserveWatchOutput",
"test": "jest",
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
},
"dependencies": {
Expand Down
6 changes: 4 additions & 2 deletions packages/rpc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"scripts": {
"lint": "buf lint",
"generate": "buf generate",
"build": "tsc"
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc"
},
"dependencies": {
"@bufbuild/protobuf": "^1.10.0",
Expand All @@ -25,7 +26,8 @@
"devDependencies": {
"@bufbuild/buf": "^1.39.0",
"@bufbuild/protoc-gen-es": "^1.10.0",
"@connectrpc/protoc-gen-connect-es": "^1.4.0"
"@connectrpc/protoc-gen-connect-es": "^1.4.0",
"@lage-run/monorepo-scripts": "workspace:^"
},
"publishConfig": {
"access": "public"
Expand Down
1 change: 1 addition & 0 deletions packages/runners/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"types": "lib/index.d.ts",
"scripts": {
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
Expand Down
2 changes: 2 additions & 0 deletions packages/scheduler-types/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
"types": "lib/index.d.ts",
"scripts": {
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
},
"dependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/scheduler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"types": "lib/index.d.ts",
"scripts": {
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
Expand Down
5 changes: 3 additions & 2 deletions packages/target-graph/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@
"main": "lib/index.js",
"types": "lib/index.d.ts",
"scripts": {
"build": "tsc",
"start": "tsc -w --preserveWatchOutput",
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
},
Expand Down
1 change: 1 addition & 0 deletions packages/worker-threads-pool/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"types": "lib/index.d.ts",
"scripts": {
"build": "monorepo-scripts tsc",
"types": "monorepo-scripts tsc",
"start": "monorepo-scripts tsc -w --preserveWatchOutput",
"test": "monorepo-scripts jest",
"lint": "monorepo-scripts lint"
Expand Down
2 changes: 1 addition & 1 deletion scripts/config/tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"moduleResolution": "Node",
"declaration": true,
"isolatedModules": true,
"isolatedDeclarations": true,
"lib": ["ES2020"],
"allowJs": true,
"strict": true,
"allowSyntheticDefaultImports": true,
"esModuleInterop": true,
Expand Down
Loading
Loading