Merged
Conversation
wdcui
approved these changes
Jun 17, 2025
Member
wdcui
left a comment
wdcui
left a comment
There was a problem hiding this comment.
Looks good to me. I left one minor comment/question.
CvvT
force-pushed
the
thread_local_storage
branch
from
cd60fed to
ad0a6f4
Compare
CvvT
force-pushed
the
thread_local_storage
branch
4 times, most recently
from
ae60479 to
d996499
Compare
jaybosamiya-ms
approved these changes
Jun 21, 2025
Member
jaybosamiya-ms
left a comment
jaybosamiya-ms
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Co-authored-by: Jay Bosamiya (Microsoft) <jayb@microsoft.com>
CvvT
force-pushed
the
thread_local_storage
branch
from
403c460 to
dbfd54b
Compare
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to address #66. Similar to how libc uses fs on x86_64 (or gs on x86) for thread-local storage, we could use the other one (i.e., gs on x86_64 and fs on x86) for litebox's TLS.
Note that on x86_64, we can directly modify fs/gs base, while on x86, we have to call syscall
set_thread_areato add an entry to GDT and updatefsselector to point to the new entry.