Open
Conversation
Contributor
|
@akorb please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current state of the code, the fTPM TA panics with the following output if
-D USE_PLATFORM_EPSis specified:This happens because in
_plat__GetEPStheEPSLenvariable which is passed toTEE_GetPropertyAsBinaryBlockis not initialized. However,TEE_GetPropertyAsBinaryBlockexpects this variable to be set to the size of the provided buffer, as explained here.It also fixes that the getting the value of the property always failed, since the property is not registered specifically for the fTPM TA, but for the whole TEE here, i.e., use
TEE_PROPSET_TEE_IMPLEMENTATIONinstead ofTEE_PROPSET_CURRENT_TA.In addition, it fixes that we might write out of buffer of the variable
EndorsementSeedby giving its actual length to_plat__GetEntropyinstead of the fixed EPS size (TEE_EPS_SIZE).