Replace __HIP_PLATFORM_AMD__ to use internal macro
#712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes platform detection by replacing direct checks for __HIP_PLATFORM_AMD__ with the MSCCLPP_DEVICE_HIP macro defined in device.hpp. The changes improve code maintainability by centralizing platform detection logic and removing an unnecessary wrapper header.
- Replaced all instances of
__HIP_PLATFORM_AMD__checks withMSCCLPP_DEVICE_HIPmacro - Removed the unnecessary
src/include/atomic.hppwrapper file - Updated includes to use
<mscclpp/atomic_device.hpp>directly and added<mscclpp/device.hpp>where needed
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/semaphore.cc | Replaced atomic.hpp include with atomic_device.hpp, updated conditional checks to use MSCCLPP_DEVICE_HIP, added [[maybe_unused]] attribute |
| src/registered_memory.cc | Added device.hpp include and updated HIP platform check to use MSCCLPP_DEVICE_HIP |
| src/include/execution_kernel.hpp | Added device.hpp include and replaced all HIP_PLATFORM_AMD checks with MSCCLPP_DEVICE_HIP for FP8 operations |
| src/include/atomic.hpp | Removed entire file as it was an unnecessary wrapper around atomic_device.hpp |
| src/ib.cc | Added device.hpp include and replaced all HIP_PLATFORM_AMD checks with MSCCLPP_DEVICE_HIP |
| src/gpu_utils.cc | Added device.hpp include and updated conditional compilation checks to use MSCCLPP_DEVICE_HIP |
| src/fifo.cc | Replaced atomic.hpp include with atomic_device.hpp |
| src/executor/executor.cc | Added device.hpp include and updated NPKit-related conditional check to use MSCCLPP_DEVICE_HIP |
| python/csrc/gpu_utils_py.cpp | Added device.hpp include and updated device type detection to use MSCCLPP_DEVICE_HIP |
| include/mscclpp/gpu_utils.hpp | Added device.hpp include and replaced all HIP_PLATFORM_AMD checks with MSCCLPP_DEVICE_HIP |
| include/mscclpp/gpu_data_types.hpp | Moved device.hpp include to top of file (before conditional platform includes) and updated platform check to use MSCCLPP_DEVICE_HIP |
Binyang2014
changed the title
MSCCLPP_DEVICE_HIP instead of __HIP_PLATFORM_AMD____HIP_PLATFORM_AMD__ to use internal macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing most of checks for
__HIP_PLATFORM_AMD__withMSCCLPP_DEVICE_HIPfor device andMSCCLPP_USE_ROCMfor host source file.