Skip to content

Add independent server IO knobs for QUIC #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mtfriesen wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add independent server IO knobs for QUIC #629

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e52cf01
test windows against common server IO
mtfriesen May 14, 2025
7fbef77
do 1es, too
mtfriesen May 14, 2025
944d265
yml
mtfriesen May 14, 2025
d34a779
don't onboard new matrix yet
mtfriesen May 15, 2025
7f0ff76
dummy commit
mtfriesen May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .github/workflows/quic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ jobs:
workflowId: ${{ github.run_id }}-${{ github.run_attempt }}

run-secnetperf-1es:
name: ${{ matrix.optional == 'TRUE' && '[UNRELIABLE]-' || '' }}azure-${{ matrix.os }}-${{ matrix.io }}-${{ matrix.role }}-${{ matrix.tls }}-${{ matrix.arch }}
name: ${{ matrix.optional == 'TRUE' && '[UNRELIABLE]-' || '' }}azure-${{ matrix.os }}-${{ matrix.io }}-${{ matrix.serverio }}-${{ matrix.role }}-${{ matrix.tls }}-${{ matrix.arch }}
needs: [prepare-matrix, build-windows, build-windows-kernel, build-unix]
strategy:
fail-fast: false
Expand Down Expand Up @@ -234,6 +234,7 @@ jobs:
-arch ${{ matrix.arch }} `
-tls ${{ matrix.tls }} `
-io ${{ matrix.io }} `
-serverio '${{ matrix.serverio }}' `
-filter '${{ github.event.client_payload.filter || inputs.filter || '' }}'
matrix: '${{ toJson(matrix) }}'
syncer-secret: ${{ secrets.NETPERF_SYNCER_SECRET }}
Expand All @@ -247,20 +248,20 @@ jobs:
if: ${{ always() }}
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882
with:
name: json-test-results-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}.json
path: json-test-results-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}.json
name: json-test-results-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}-${{ matrix.serverio }}.json
path: json-test-results-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}-${{ matrix.serverio }}.json
- name: Upload Logs
if: ${{ always() }}
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882
with:
name: logs-${{ matrix.env }}-${{ matrix.role }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}
name: logs-${{ matrix.env }}-${{ matrix.role }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}-${{ matrix.serverio }}
path: artifacts/logs
if-no-files-found: ignore
- name: Upload Full Latency Curves
if: ${{ always() }}
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882
with:
name: latency-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}
name: latency-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}-${{ matrix.serverio }}
path: latency.txt
if-no-files-found: ignore

Expand All @@ -269,7 +270,7 @@ jobs:
# NOTE: tag == env
#
run-secnetperf:
name: ${{ matrix.optional == 'TRUE' && '[UNRELIABLE]-' || '' }}lab-${{ matrix.os }}-${{ matrix.io }}-${{ matrix.tls }}-${{ matrix.arch }}
name: ${{ matrix.optional == 'TRUE' && '[UNRELIABLE]-' || '' }}lab-${{ matrix.os }}-${{ matrix.io }}-${{ matrix.serverio }}-${{ matrix.tls }}-${{ matrix.arch }}
needs: [prepare-matrix, build-windows, build-windows-kernel, build-unix]
strategy:
fail-fast: false
Expand Down Expand Up @@ -322,25 +323,26 @@ jobs:
-arch ${{ matrix.arch }} `
-tls ${{ matrix.tls }} `
-io ${{ matrix.io }} `
-serverio '${{ matrix.serverio }}' `
-filter '${{ github.event.client_payload.filter || inputs.filter || '' }}'
- name: Upload Test Results JSON
if: ${{ always() }}
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882
with:
name: json-test-results-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}.json
path: json-test-results-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}.json
name: json-test-results-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}-${{ matrix.serverio }}.json
path: json-test-results-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}-${{ matrix.serverio }}.json
- name: Upload Logs
if: ${{ always() }}
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882
with:
name: logs-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}
name: logs-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}-${{ matrix.serverio }}
path: artifacts/logs
if-no-files-found: ignore
- name: Upload Full Latency Curves
if: ${{ always() }}
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882
with:
name: latency-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}
name: latency-${{ matrix.env }}-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.tls }}-${{ matrix.io }}-${{ matrix.serverio }}
path: latency.txt
if-no-files-found: ignore

Expand Down
Loading