Skip to content

add purify graph pass #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
xiayuqing0622 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add purify graph pass #271

xiayuqing0622 wants to merge 1 commit into from

Conversation

@xiayuqing0622
Copy link
Contributor

@xiayuqing0622 xiayuqing0622 commented May 19, 2021

add purify graph pass: remove node not used by output.

@xiayuqing0622 xiayuqing0622 requested a review from lynex May 19, 2021 08:35
@wenxcs
Copy link
Contributor

wenxcs commented May 19, 2021

Is there any sample to test this pass

@wenxcs
Copy link
Contributor

wenxcs commented May 26, 2021 •
edited
Loading

https://github.com/microsoft/nnfusion/blob/master/src/nnfusion/core/operators/generic_op/generic_op_define/Scatter.cpp

This is an op that doesn't have output.

And I think this should be called as Dead Node Elimination( which is called as Dead Statement Elimination in compiler optmization).

@wenxcs wenxcs marked this pull request as draft March 8, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lynex lynex Awaiting requested review from lynex

1 more reviewer

@wenxcs wenxcs wenxcs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xiayuqing0622 @wenxcs