feat(nova/react-test-utils): make types for referenceEntries stronger #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously did some work to add good, strong types for parameters for nova decorator. One of the big things was making sure that
referenceEntriesfields match props of the component. However, we are now verifying only if the name of the prop matches, instead of of actually checking the value, which causes a number of random errors for folks using this in 1JS.In scope of this PR we add a validation of return type of each field in
referenceEntries. So previouslynow
Thanks to @MikeBarker-MSFT for providing a first version of this within 1JS