[MDiff] Introduce Metadata Diff functionality in Actions Hub#1329
Open
MrRishabhJain wants to merge 65 commits intomainfrom
Open
[MDiff] Introduce Metadata Diff functionality in Actions Hub#1329MrRishabhJain wants to merge 65 commits intomainfrom
MrRishabhJain wants to merge 65 commits intomainfrom
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
priyanshu92
reviewed
Oct 8, 2025
Comment on lines
+505
to
+531
| "command": "microsoft.powerplatform.pages.metadataDiff.triggerFlow", | ||
| "title": "Compare with Environment", | ||
| "category": "Power Pages Metadata Diff", | ||
| "icon": "$(cloud-download)" | ||
| }, | ||
| { | ||
| "command": "microsoft.powerplatform.pages.metadataDiff.generateReport", | ||
| "title": "Generate HTML Report", | ||
| "category": "Power Pages Metadata Diff", | ||
| "icon": "$(markdown)" | ||
| }, | ||
| { | ||
| "command": "microsoft.powerplatform.pages.metadataDiff.resync", | ||
| "title": "Re-sync", | ||
| "category": "Power Pages Metadata Diff", | ||
| "icon": "$(refresh)" | ||
| }, | ||
| { | ||
| "command": "microsoft.powerplatform.pages.metadataDiff.clearView", | ||
| "title": "Clear View", | ||
| "category": "Power Pages Metadata Diff", | ||
| "icon": "$(clear-all)" | ||
| }, | ||
| { | ||
| "command": "microsoft.powerplatform.pages.metadataDiff.exportReport", | ||
| "title": "Export Comparison View", | ||
| "category": "Power Pages Metadata Diff", |
Contributor
There was a problem hiding this comment.
All of these should be localized.
priyanshu92
reviewed
Oct 8, 2025
src/client/power-pages/actions-hub/ActionsHubTreeDataProvider.ts
Outdated
Show resolved
Hide resolved
src/client/power-pages/actions-hub/ActionsHubTreeDataProvider.ts
Outdated
Show resolved
Hide resolved
src/client/power-pages/actions-hub/ActionsHubTreeDataProvider.ts
Outdated
Show resolved
Hide resolved
src/client/power-pages/actions-hub/ActionsHubTreeDataProvider.ts
Outdated
Show resolved
Hide resolved
| } | ||
| }); | ||
|
|
||
| vscode.commands.registerCommand("microsoft.powerplatform.pages.metadataDiff.triggerFlow", async () => { |
Contributor
There was a problem hiding this comment.
Can we please refactor this file?
- When registering commands, you can register single methods instead of defining the logic inline.
- The logic itself can be broken into multiple reusable functions. A single function seems to be doing too much right now.
|
|
||
| vscode.commands.registerCommand("microsoft.powerplatform.pages.actionsHub.siteDetails", showSiteDetails), | ||
|
|
||
| vscode.commands.registerCommand("microsoft.powerplatform.pages.actionsHub.compareWithLocal", compareWithLocal), |
Contributor
There was a problem hiding this comment.
This should only be registered when metadata diff feature is enabled, right?
… and MetadataDiffWrapperTreeItem classes
…ge logic in ActionsHubTreeDataProvider
…tadata diff commands
…tion for diff titles
Contributor
|
MetadataDiffTreeDataProvider.ts and src/client/power-pages/metadata-diff/MetadataDiffCommands.ts can be reviewed once for telemetry events capturing the tracking events and debugging events. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.