Bump pxt 12.x and some other changes #1052

THEb0nny · 2024-03-19T17:29:50Z

After switching to pxt-core v10, fieldmotors break.
Related to this.

I understand that these changes should be considered after this
#1048

microsoft/pxt-microbit#5496
microsoft/pxt#9865

THEb0nny · 2024-03-20T08:19:52Z

Fixed all fields field_motors, field_ports, field_brickbuttons, field_music except field_color. When choosing a color, the color does not change. There is no error in the console.

Replacing ports with images. field ports has been removed. Almost completely repeats the functionality.

THEb0nny · 2024-03-20T08:47:17Z

Replacing field ports to images. field ports has been removed. Almost completely repeats the functionality.

All sensor blocks that used field_ports had to register this. I don’t know how it could have been done differently without repeating these lines.

this.fieldOptions.columns="4"
this.fieldOptions.width="300"

Accidentally added field_colors changes to this commit. He's not ready. There are no errors, but the color selection does not work.

Where did turnRatio come from?

The last change to field_colour removed the addition of className. It’s not clear for what reason, but I’m adding it myself now.

The new version of FieldColorNumber does not apply applyColour() inside the doValueUpdate_() method. Secondly, the applyColour() method was redesigned in the new version so that it no longer worked with this enum code.

THEb0nny · 2024-03-21T21:17:29Z

The colorenum field has been fixed.

THEb0nny · 2024-04-22T09:03:44Z

@jwunderl @riknoll can someone see all the changes?

Fixes for new versions of Blockly, Fixing buttons in showEditor_(). Return scroll otherwise the items won't fit

Fixes for new versions of Blockly.

Copilot

Pull Request Overview

This PR upgrades to pxt-core v11 and pxt-common-packages v12, updates block field editors across sensor libraries to use image pickers with layout options, refactors custom field editor implementations, and adds EV3 debugging and improved serial-buffer parsing.

Bump pxt-core and pxt-common-packages versions in package.json
Switch block fieldEditors from "ports" to "images" with new fieldOptions in sensor libs
Restructure/refactor fieldeditors (motors, music, color, brickbuttons) and update reference paths
Add dumpInputCmd/dumpOutputCmd helpers in editor/wrap.ts and enhance buffer parsing in editor/deploy.ts

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
package.json	Updated pxt-core/pxt-common-packages versions
libs/*/ultrasonic-sensor/ultrasonic.ts	Changed fieldEditor to "images" with columns/width options
libs/storage/storage-core.ts	Moved `Separators` enum out of namespace and rewrapped namespace
fieldeditors/field_motors.ts	Refactored `FieldMotors` rendering and dropdown logic
editor/wrap.ts	Added `dumpInputCmd`/`dumpOutputCmd` for detailed HF2 logging
editor/deploy.ts	Improved WebSerialPackageIO bufferSize method and parsing logic

Copilot · 2025-06-17T23:30:03Z

libs/storage/storage-core.ts

+enum Separators {
+    //% block="comma"
+    Comma,
+    //% block="semicolon"
+    Semicolon
+}

-    export enum Separators {
-        //% block="comma"
-        Comma,
-        //% block="semicolon"
-        Semicolon
-    }
+namespace storage {


Moving Separators to the top-level without export and outside namespace storage breaks references to storage.Separators. Re-export it inside namespace storage or add export.

Suggested change

enum Separators {

//% block="comma"

Comma,

//% block="semicolon"

Semicolon

}

export enum Separators {

//% block="comma"

Comma,

//% block="semicolon"

Semicolon

}

namespace storage {

namespace storage {

export enum Separators {

//% block="comma"

Comma,

//% block="semicolon"

Semicolon

}

Copilot · 2025-06-17T23:30:03Z

editor/deploy.ts

+                    console.warn(`Received larger bufer then command command: ${buffer.length} recieved but waiting for ${size}`);
+                    let tmp = buffer.slice(0, size - 1);
+                    this.onData(new Uint8Array(tmp));
+                    tmp = buffer.slice(size, buffer.length - 1);
+                    buffer = tmp;
+                    console.debug(`Next buffer size: ${this.bufferSize(buffer)}`);
                } else {
-                    console.warn("Incomplete command " + size);
+                    console.warn(`Incomplete command: ${buffer.length} recieved but waiting for ${size}. Keep waiting...`);


Fix spelling and grammar: "bufer" → "buffer", "then" → "than", and "recieved" → "received".

Copilot · 2025-06-17T23:30:04Z

editor/deploy.ts

+                    let tmp = buffer.slice(0, size - 1);
+                    this.onData(new Uint8Array(tmp));
+                    tmp = buffer.slice(size, buffer.length - 1);


Using slice(0, size - 1) drops the last byte of the intended payload. It should be slice(0, size) to include all bytes of the frame header and body.

Suggested change

let tmp = buffer.slice(0, size - 1);

this.onData(new Uint8Array(tmp));

tmp = buffer.slice(size, buffer.length - 1);

let tmp = buffer.slice(0, size);

this.onData(new Uint8Array(tmp));

tmp = buffer.slice(size, buffer.length);

I don't remember what this change was connected with, but Bluetooth download didn't break for me.

editor/wrap.ts

Fix for no voice acting when mouse is hovered. But console shows error: Uncaught (in promise) AbortError: The play() request was interrupted by a call to pause(). https://goo.gl/LdLk22

THEb0nny · 2025-06-18T05:49:18Z

@abchatra @riknoll pr is not ready yet.
So far, support is not completed, without it the appearance is very broken, but I am in the process, although it is difficult for me to figure it out, although I look at other Microbit and Arcade projects.
And there are some mistakes that do not seem to affect the functionality, but are displayed in the console.
For example, there is a simulator crash, I have not reached that yet.

If they gave me some tips how to solve or something was not the best made, it would be great.

There is a problem in pxsim.AudioContextManager, which manifests itself in the fact that if you quickly move the mouse cursor, an error appears in the console: Uncaught (in promise) AbortError: The play() request was interrupted by a call to pause(). https://goo.gl/LdLk22

Replacing substr with slice.

Optimized the withdrawal of logs about file download. DumpinPutCmd Reply Status should have been by BYTE 6, not 5. Fixed.

Change to allow the use of underscores in file names.

Return scroll for default blocklyDropDownContent class.

THEb0nny · 2025-07-01T20:33:58Z

Scrolling is missing in the new version of blockly. Scroll y had to be returned.

An error that prevented the simulator from starting, citing errors when executing brick.readButtons() and hashDevices(). Simulator crashed, no error handler Error: TypeError: Expected type Buffer but received type object. Here buf() simply returns an object with a data: Uint8Array field, not a real Buffer (i.e. RefBuffer), which the PXT runtime expects. The BufferMethods.slice, getNumber, etc. methods expect an object with a Buffer prototype and methods, not a raw JS object { data: Uint8Array }. By returning a full Buffer from buf() you fix this.

THEb0nny · 2025-07-10T13:16:29Z

Fixed simulator crash in last commit.

THEb0nny · 2025-11-21T10:39:31Z

I noticed one thing: the EV3 code stops immediately after loading. I don't understand what's causing this. And I don't understand when this happened. I don't remember if I tested it on hardware right away when creating the PR.

@abchatra @riknoll Is this related to the need to update the runtime due to increased pxt-core versions? core---linux?

abchatra · 2025-11-21T17:19:53Z

We haven't done any intentional change and don't have bandwidth either to debug.

THEb0nny added 13 commits February 7, 2024 15:30

consume-pxteditor-changes-and-upgrade-code

118e7af

Update deploy.ts

f02e716

pxt-core-and-common-packages-bump

20158f9

Update extension.ts

969d2e5

Update field_music.ts

6ac7b2e

Update field_ports.ts

c6f7cb1

Update field_music.ts

c0a712c

Update field_color.ts

5816038

Update field_music.ts

53a46bf

Update field_music.ts

62efa39

Update field_motors.ts

536dbad

Update field_brickbuttons.ts

23e2f7c

Update field_motors.ts

9bf4852

microsoft/pxt-microbit#5496

THEb0nny added 3 commits March 20, 2024 11:34

Update field_ports.ts

e67e668

del_field_ports

bc459b5

Replacing ports with images. field ports has been removed. Almost completely repeats the functionality.

Update field_brickbuttons.ts

dbaff3f

THEb0nny mentioned this pull request Mar 20, 2024

The great Blockly upgrade microsoft/pxt#9865

Merged

THEb0nny added 5 commits March 20, 2024 12:24

Update ultrasonic.ts

ec13cf1

Update field_color.ts

83c0e91

turnRatio-del

329bd21

Where did turnRatio come from?

Update field_color.ts

0c685bc

The last change to field_colour removed the addition of className. It’s not clear for what reason, but I’m adding it myself now.

return-applyColour()

c63d81e

The new version of FieldColorNumber does not apply applyColour() inside the doValueUpdate_() method. Secondly, the applyColour() method was redesigned in the new version so that it no longer worked with this enum code.

THEb0nny added 4 commits March 25, 2024 13:23

bump_10-0-13

cd9b5fe

bump-10-0-14

54eb2e5

bump-10-0-16

679c698

bump-10.0.18

ee43257

THEb0nny added 9 commits May 4, 2025 21:14

Update storage-core.ts

5fd4c91

bump-pxt-11.4.28-and-common-packages-12.3.31

d846656

Update field_motors.ts

c77058b

Fixes for new versions of Blockly, Fixing buttons in showEditor_(). Return scroll otherwise the items won't fit

Update field_brickbuttons.ts

0d0b93c

Update field_brickbuttons.ts

419f6d9

Update field_music.ts

0cad591

Fixes for new versions of Blockly.

Update storage-core.ts

df15c6d

Update field_motors.ts, field_music.ts

72cb0d2

Update field_music.ts

f5ff38f

abchatra requested review from Copilot and riknoll June 17, 2025 23:27

Copilot AI reviewed Jun 17, 2025

View reviewed changes

Update field_music.ts

0548d6b

Fix for no voice acting when mouse is hovered. But console shows error: Uncaught (in promise) AbortError: The play() request was interrupted by a call to pause(). https://goo.gl/LdLk22

THEb0nny added 8 commits June 18, 2025 08:58

theme-support

251c326

Update field_music.ts

58a22a9

Replacing substr with slice.

Bluetooth log fix and improvements

b34009d

Optimized the withdrawal of logs about file download. DumpinPutCmd Reply Status should have been by BYTE 6, not 5. Fixed.

Update deploy.ts

ac0cd8e

allow_underscores_in_filename

c0f295a

Change to allow the use of underscores in file names.

bump-pxt-11.4.40

b028d10

Update blockly.less

69de621

Return scroll for default blocklyDropDownContent class.

bump-pxt-12.1.5-and-common-packages-13.1.0

650b8a1

THEb0nny changed the title ~~Bump pxt 10 and some other changes~~ Bump pxt 12.x and some other changes Aug 5, 2025

bump-pxt-12.2.8-and-common-packages-13.1.4

35e898d

Bump pxt 12.x and some other changes #1052

Are you sure you want to change the base?

Bump pxt 12.x and some other changes #1052

Uh oh!

Conversation

THEb0nny commented Mar 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

THEb0nny commented Mar 20, 2024

Uh oh!

THEb0nny commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

THEb0nny commented Mar 21, 2024

Uh oh!

THEb0nny commented Apr 22, 2024

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

THEb0nny Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

THEb0nny commented Jun 18, 2025

Uh oh!

THEb0nny commented Jul 1, 2025

Uh oh!

THEb0nny commented Jul 10, 2025

Uh oh!

THEb0nny commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abchatra commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

THEb0nny commented Mar 19, 2024 •

edited

Loading

THEb0nny commented Mar 20, 2024 •

edited

Loading

THEb0nny commented Nov 21, 2025 •

edited

Loading