Skip to content

Add TS types for Serial object #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maciejmrozinski wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add TS types for Serial object #989

maciejmrozinski wants to merge 2 commits into from

Conversation

@maciejmrozinski
Copy link
Contributor

@maciejmrozinski maciejmrozinski commented Sep 15, 2020 •
edited
Loading

Replacing custom Serial types with @types package:

  • added @types/dom-serial npm package
  • bumped typescript version (needed for WritableStream DOM definition used in Serial)
  • bumped jquery types version (conflicted with newer typescript)
  • make it works in newest Chrome

@pelikhan pelikhan self-requested a review November 13, 2020 12:55
@pelikhan
Copy link
Member

pelikhan commented Nov 13, 2020

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pelikhan pelikhan Awaiting requested review from pelikhan

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maciejmrozinski @pelikhan