fix(api-extractor): preserve export keyword for namespace re-exports #5517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5516
When a namespace contains
export { Foo, Bar };re-export declarations, api-extractor was incorrectly stripping theexportkeyword, producing{ Foo, Bar, };which is syntactically invalid TypeScript.Input:
Before (invalid):
After (valid):
Details
The issue is in
DtsRollupGenerator.tsandApiReportGenerator.ts. Both files unconditionally skip allExportKeywordtokens (lines ~272-276), then re-add them for declaration types (interface, class, enum, namespace, function, type). However,ExportDeclarationnodes (likeexport { Foo }) were not handled, so theexportkeyword was stripped but never restored.The fix checks if an
ExportKeywordis part of anExportDeclarationthat is inside aModuleBlock(namespace body), and if so, preserves it.How it was tested
export { }declarations