Add git to Dockerfile build dependencies#354
Merged
achamayou merged 2 commits intorego_take2_regocppfrom Feb 4, 2026
Merged
Conversation
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
achamayou
approved these changes
Feb 4, 2026
Copilot
AI
changed the title
[WIP] Add git dependency to address PR feedback
Add git to Dockerfile build dependencies
Feb 4, 2026
Copilot stopped work on behalf of
achamayou due to an error
February 4, 2026 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMake build uses
FetchContentwithGIT_REPOSITORYto clone rego-cpp, but git was not explicitly listed as a build dependency in the Dockerfile.Changes
gitto package installation indocker/Dockerfileline 33 (builder stage)The package was previously installed implicitly via transitive dependencies, but should be explicit given the direct usage in
app/CMakeLists.txt.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.