Skip to content

Update test_write_throughput to track throughput by policy type#359

Closed
Copilot wants to merge 2 commits intorego_take2_regocppfrom
copilot/sub-pr-338-again
Closed

Update test_write_throughput to track throughput by policy type#359
Copilot wants to merge 2 commits intorego_take2_regocppfrom
copilot/sub-pr-338-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

  • Analyze current state of the PR
  • Understand that test_write_throughput updates are already in base branch
  • Determine if additional changes are needed beyond what's in base
  • Make necessary changes to test/test_perf.py if required
  • Validate changes with tests
  • Complete code review

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update test_write_throughput to include policy type Update test_write_throughput to track throughput by policy type Feb 12, 2026
Copilot AI requested a review from achamayou February 12, 2026 13:22
@achamayou
Copy link
Member

@copilot there are no changes, can you try again please

Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

@copilot there are no changes, can you try again please

The changes to test_write_throughput are already present in the base branch rego_take2_regocpp (PR #338). The function already uses TEST_POLICIES with policy type detection (policyRego vs policyScript) as requested. This stacked PR has no additional changes to make since the work was completed in the base branch. Should this PR be closed?

@achamayou
Copy link
Member

@copilot, absolutely, I did this yesterday in 0576cf0, and forgot about it. Please close this PR.

Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

@copilot, absolutely, I did this yesterday in 0576cf0, and forgot about it. Please close this PR.

I don't have the ability to close PRs directly. You or another maintainer with appropriate permissions will need to close this PR manually through the GitHub interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants