Added a cleanall option, documented cleandeps, normalized args to "--" #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@anmolah can you take a look? |
anmolah
reviewed
Mar 23, 2018
Contributor
anmolah
left a comment
anmolah
left a comment
There was a problem hiding this comment.
I left a comment. Was that addressed ? Is there way to see diff between iterations ?
| This will do a full build of the project with the output being placed into the `out` directory. For more options see `runbuild.sh -h`. | ||
|
|
||
| Additionally in order to build and create the installer packages you can pass in the `-createinstaller` option to the script: | ||
| Additionally in order to build and create the installer packages you can pass in the `--createinstaller` option to the script: |
Contributor
There was a problem hiding this comment.
Provide both full and short param as options. Also make sure to transition this change to the internal version as well
ammarZaidi
pushed a commit
to ammarZaidi/service-fabric
that referenced
this pull request
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a "--cleanall" flag and documented the "--cleandeps" option. This is to facilitate users who are having trouble with dependencies that have been improperly installed.
I also normalized the long parameters to match the typical Linux pattern of "--foo" instead of the more powershell-like "-foo"