Bug Fix - Set self.logger_stream to None in StdLogger.stop() (#708) #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a bug in the
StdLoggermodule where callingstop()multiple times or callinglog()after the logger has been stopped would result inValueErrorexceptions.The issue arises because the internal
self.logger_streamreference was not cleared (set to None) after therestore()method was called instop(). This led to subsequent attempts to use the old, inactive stream object, which had a closed file handle.This change adds the necessary step to set
self.logger_stream = Nonein thestop()method after the stream is restored, ensuring the logger's state is correctly reset.Fixes #708 .