Enable testing of LSP server #192
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # schedules: | ||
| # - cron: "0 19 * * Sun" # time is in UTC | ||
| # displayName: Sunday overnight run | ||
| # always: true | ||
| # branches: | ||
| # include: | ||
| # - main | ||
|
|
||
| pr: none | ||
| trigger: none | ||
|
|
||
| pool: | ||
| name: TypeScript-1ES-Large | ||
| demands: | ||
| - ImageOverride -equals azure-linux-3 | ||
|
|
||
| extends: | ||
| template: azure-pipelines-gitTests-template.yml | ||
| parameters: | ||
| ENTRYPOINT: lsp | ||
| OLD_VERSION: '0' | ||
| NEW_VERSION: latest | ||
| LANGUAGE: TypeScript | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,16 +3,16 @@ import { mainAsync, reportError, TsEntrypoint } from "./main"; | |
|
|
||
| const { argv } = process; | ||
|
|
||
| if (argv.length < 11) { | ||
gabritto marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| console.error(`Usage: ${path.basename(argv[0])} ${path.basename(argv[1])} <ts_entrypoint> <old_ts_npm_version> <new_ts_npm_version> <repo_list_path> <worker_count> <worker_number> <result_dir_name> <diagnostic_output> <prng_seed> <use_tempfs>?`); | ||
| process.exit(-1); | ||
| } | ||
|
|
||
| const [,, entrypoint, oldTsNpmVersion, newTsNpmVersion, repoListPath, workerCount, workerNumber, resultDirName, diagnosticOutput, prngSeed, tmpfs] = argv; | ||
|
|
||
| mainAsync({ | ||
| testType: "github", | ||
| tmpfs: tmpfs && tmpfs.toLowerCase() === "false" ? false : true, | ||
|
Member
Author
There was a problem hiding this comment. If I ran this with
Member
There was a problem hiding this comment. Yeah, no idea on this one. @jakebailey or @sandersn might have ideas, I don't know anything about tmpfs.
Member
There was a problem hiding this comment. I don't see how this would happen, if you don't use tmpfs it goes mega slow. Where did it give that error? Maybe you're just ooming?
Member
Author
There was a problem hiding this comment. I can try and reproduce it again, but pretty sure the error was caused by one of the mount commands that we run when |
||
| entrypoint: entrypoint as TsEntrypoint, | ||
| diagnosticOutput: diagnosticOutput.toLowerCase() === "true", | ||
| buildWithNewWhenOldFails: false, | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there parameters missing to be compatible with the bot? Or are we not doing the bot for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I haven't updated the code to handle comparing versions. I don't know how the fuzzer is going to behave, so I wanted to get a sense of it before enabling the whole comparison of versions, and I also need to set up the regular compiler entry point for tsgo because that's probably what would be most useful. If you think I'm being overly cautious, I could set up the whole thing here, but I'm thinking e.g. for the compiler entry point we'll have deprecations to deal with.