Support --pprofDir option with --watch #2417
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables profiling support for the TypeScript compiler's watch mode by handling --pprofDir with --watch. Previously, profiling would stop immediately when watch mode started its monitoring loop, preventing meaningful profiling data collection during file watching operations.
Key Changes
- Adds signal handling to gracefully stop profiling on interrupt signals (SIGINT/SIGTERM) when watch mode is active
- Removes the immediate
defer profileSession.Stop()call for watch mode to allow continuous profiling
| <-ctx.Done() | ||
| profileSession.Stop() | ||
| os.Exit(int(tsc.ExitStatusSuccess)) | ||
| }() |
There was a problem hiding this comment.
When watch mode is disabled, the profiling session is never stopped because the defer profileSession.Stop() was removed. The defer statement should be preserved and only skipped when watch mode is enabled. Consider adding else { defer profileSession.Stop() } after the watch mode block.
| }() | |
| }() | |
| } else { | |
| defer profileSession.Stop() |
| defer stop() | ||
| <-ctx.Done() | ||
| profileSession.Stop() | ||
| os.Exit(int(tsc.ExitStatusSuccess)) |
There was a problem hiding this comment.
Calling os.Exit() from a goroutine bypasses deferred cleanup functions in the main goroutine and can lead to incomplete cleanup. Consider using a channel or context cancellation to signal the main goroutine to exit gracefully instead.
tmm1
force-pushed
the
tmm1/watch-pprof
branch
from
b755b17 to
9ab9b8d
Compare
1 participant
I would like to improve #1317, and step one is being able to profile what's currently happening.