Skip to content

fix/NRE generate model #9410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 2 commits into from
Jan 19, 2026
+11 −2
Merged

fix/NRE generate model #9410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
014fae8
fix: null reference exception on model import if the member schema ca…
baywet Jan 19, 2026
fdb0fe0
docs: adds chronus entry for null reference exception
baywet Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/fix-NRE-generate-model-2026-0-19-9-51-29.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@typespec/openapi3"
---

importer - null reference exception if member schema cannot be resolved
6 changes: 4 additions & 2 deletions packages/openapi3/src/cli/actions/convert/generators/generate-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,12 @@ function generateUnion(union: TypeSpecUnion, context: Context): string {
return "";
}

const memberSchema = "$ref" in member ? context.getSchemaByRef(member.$ref)! : member;
const memberSchema = "$ref" in member ? context.getSchemaByRef(member.$ref) : member;

const propertySchema =
memberSchema.properties && memberSchema.properties[union.schema.discriminator.propertyName];
memberSchema &&
memberSchema.properties &&
memberSchema.properties[union.schema.discriminator.propertyName];
const value =
(union.schema.discriminator?.mapping && "$ref" in member
? Object.entries(union.schema.discriminator.mapping).find((x) => x[1] === member.$ref)?.[0]
Expand Down
Loading