Merged
Conversation
Contributor
|
@vipcxj, thanks for the PR, you can make a patch for the upstream changes instead of changing the upstream repository. |
Contributor
Author
|
@JonLiu1993 updated, using patch instead of changing the upstream repository. |
JonLiu1993
reviewed
Mar 7, 2024
Contributor
|
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
JonLiu1993
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my pr for upstream. There has been no response for one week, so I think the upstream is not maintained. So I decide change the repo to my fork. If the author resume, I will switch back.
./vcpkg x-add-version --alland committing the result.