Skip to content

[asiochan] fix MiSo1289#10#37161

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
vipcxj:asiochan
Mar 8, 2024
Merged

[asiochan] fix MiSo1289#10#37161
vicroms merged 1 commit intomicrosoft:masterfrom
vipcxj:asiochan

Conversation

@vipcxj
Copy link
Contributor

@vipcxj vipcxj commented Mar 6, 2024

Here is my pr for upstream. There has been no response for one week, so I think the upstream is not maintained. So I decide change the repo to my fork. If the author resume, I will switch back.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision invalid and removed category:port-bug The issue is with a library, which is something the port should already support labels Mar 6, 2024
@JonLiu1993
Copy link
Contributor

@vipcxj, thanks for the PR, you can make a patch for the upstream changes instead of changing the upstream repository.

@JonLiu1993 JonLiu1993 marked this pull request as draft March 6, 2024 06:42
@vipcxj
Copy link
Contributor Author

vipcxj commented Mar 6, 2024

@JonLiu1993 updated, using patch instead of changing the upstream repository.

@vipcxj vipcxj marked this pull request as ready for review March 6, 2024 14:25
@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support and removed category:port-update The issue is with a library, which is requesting update new revision invalid labels Mar 7, 2024
@JonLiu1993 JonLiu1993 marked this pull request as draft March 7, 2024 01:56
@JonLiu1993
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@vipcxj vipcxj marked this pull request as ready for review March 7, 2024 16:08
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 8, 2024
@vicroms vicroms merged commit 081abea into microsoft:master Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments